sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-04-29 02:37:25 +09:00
Code Issues Packages Projects Releases Wiki Activity

Code quality improvements

Browse Source
This commit is contained in:
Dylan Nantz 2022-12-20 13:33:33 -05:00
parent 42dbb0bfd0
commit 4a1a023f9e
3 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game.Rulesets.Mania.Tests/Mods/TestSceneManiaModHidden.cs
View File

@ -14,6 +14,6 @@ namespace osu.Game.Rulesets.Mania.Tests.Mods
[TestCase(0.5f)] [TestCase(0.5f)]
[TestCase(0.2f)] [TestCase(0.2f)]
[TestCase(0.8f)] [TestCase(0.8f)]
public void TestCoverage(float Coverage) => CreateModTest(new ModTestData { Mod = new ManiaModHidden { CoverageAmount = { Value = Coverage } }, PassCondition = () => true }); public void TestCoverage(float coverage) => CreateModTest(new ModTestData { Mod = new ManiaModHidden { CoverageAmount = { Value = coverage } }, PassCondition = () => true });
} }
} }

5
osu.Game.Rulesets.Mania/Mods/ManiaModHidden.cs
View File

@ -15,7 +15,7 @@ namespace osu.Game.Rulesets.Mania.Mods
public override LocalisableString Description => @"Keys fade out before you hit them!"; public override LocalisableString Description => @"Keys fade out before you hit them!";
public override double ScoreMultiplier => 1; public override double ScoreMultiplier => 1;
[SettingSource("Coverage", "How much of the playfield notes should be hidden for.")] [SettingSource("Coverage", "The proportion of playfield height that notes will be hidden for.")]
public BindableNumber<float> CoverageAmount { get; } = new BindableFloat(0.5f) public BindableNumber<float> CoverageAmount { get; } = new BindableFloat(0.5f)
{ {
Precision = 0.01f, Precision = 0.01f,
@ -23,7 +23,8 @@ namespace osu.Game.Rulesets.Mania.Mods
MaxValue = 0.8f, MaxValue = 0.8f,
Default = 0.5f, Default = 0.5f,
}; };
public override float Coverage => CoverageAmount.Value;
protected override float Coverage => CoverageAmount.Value;
public override Type[] IncompatibleMods => base.IncompatibleMods.Append(typeof(ManiaModFadeIn)).ToArray(); public override Type[] IncompatibleMods => base.IncompatibleMods.Append(typeof(ManiaModFadeIn)).ToArray();

2
osu.Game.Rulesets.Mania/Mods/ManiaModPlayfieldCover.cs
View File

@ -22,7 +22,7 @@ namespace osu.Game.Rulesets.Mania.Mods
/// </summary> /// </summary>
protected abstract CoverExpandDirection ExpandDirection { get; } protected abstract CoverExpandDirection ExpandDirection { get; }
public virtual float Coverage { get => 0.5f; } protected virtual float Coverage => 0.5f;
public virtual void ApplyToDrawableRuleset(DrawableRuleset<ManiaHitObject> drawableRuleset) public virtual void ApplyToDrawableRuleset(DrawableRuleset<ManiaHitObject> drawableRuleset)
{ {