sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-05-06 22:27:25 +09:00
Code Issues Packages Projects Releases Wiki Activity

Fix unprotected access to potentially-null DI'd dialog overlay

Browse Source
This commit is contained in:
Bartłomiej Dach 2022-03-22 22:10:05 +01:00
parent f3aad77239
commit 51a1721bc9
No known key found for this signature in database
GPG Key ID: BCECCD4FA41F6497
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
osu.Game/Tests/Visual/EditorTestScene.cs
View File

@ -97,6 +97,7 @@ namespace osu.Game.Tests.Visual
protected class TestEditor : Editor protected class TestEditor : Editor
{ {
[Resolved(canBeNull: true)] [Resolved(canBeNull: true)]
[CanBeNull]
private DialogOverlay dialogOverlay { get; set; } private DialogOverlay dialogOverlay { get; set; }
public new void Undo() => base.Undo(); public new void Undo() => base.Undo();
@ -120,7 +121,7 @@ namespace osu.Game.Tests.Visual
public override bool OnExiting(IScreen next) public override bool OnExiting(IScreen next)
{ {
// For testing purposes allow the screen to exit without saving on second attempt. // For testing purposes allow the screen to exit without saving on second attempt.
if (!ExitConfirmed && dialogOverlay.CurrentDialog is PromptForSaveDialog saveDialog) if (!ExitConfirmed && dialogOverlay?.CurrentDialog is PromptForSaveDialog saveDialog)
{ {
saveDialog.PerformAction<PopupDialogDangerousButton>(); saveDialog.PerformAction<PopupDialogDangerousButton>();
return true; return true;