sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-07-01 16:29:58 +09:00
Code Issues Packages Projects Releases Wiki Activity

Use ComputeAccuracy to get imminent accuracy

Browse Source
This commit is contained in:
Dean Herbert
2023-01-18 18:08:58 +09:00
parent 0b1e5c0f53
commit 522bb8bcca
2 changed files with 24 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
osu.Game/Rulesets/Mods/ModAccuracyChallenge.cs
View File

@ -51,11 +51,22 @@ namespace osu.Game.Rulesets.Mods
protected override bool FailCondition(HealthProcessor healthProcessor, JudgementResult result)
{
// accuracy calculation logic taken from `ScoreProcessor`. should be updated here if the formula ever changes.
if (!result.Type.IsScorable() || result.Type.IsBonus())
return false;
return scoreProcessor.Accuracy.Value < MinimumAccuracy.Value;
return getAccuracyWithImminentResultAdded(result) < MinimumAccuracy.Value;
}
private double getAccuracyWithImminentResultAdded(JudgementResult result)
{
var score = new ScoreInfo { Ruleset = scoreProcessor.Ruleset.RulesetInfo };
// This is super ugly, but if we don't do it this way we will not have the most recent result added to the accuracy value.
// Hopefully we can improve this in the future.
scoreProcessor.PopulateScore(score);
score.Statistics[result.Type]++;
return scoreProcessor.ComputeAccuracy(score);
}
}