sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-07-02 00:40:09 +09:00
Code Issues Packages Projects Releases Wiki Activity

Greatly improve performance when many hidden panels are on-screen

Browse Source
This commit is contained in:
Dean Herbert
2017-12-17 05:53:13 +09:00
parent 5d7413f19c
commit 54cc6fadf9
3 changed files with 44 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
osu.Game/Screens/Select/Carousel/CarouselItem.cs
View File

@ -29,12 +29,11 @@ namespace osu.Game.Screens.Select.Carousel
List<DrawableCarouselItem> items = new List<DrawableCarouselItem>();
var self = drawableRepresentation.Value;
if (self != null) items.Add(self);
if (self?.IsPresent == true) items.Add(self);
if (InternalChildren != null)
foreach (var c in InternalChildren)
// if (!c.Filtered) <- potential optimisation at the cost of no fade out animations.
items.AddRange(c.Drawables);
items.AddRange(c.Drawables);
return items;
}
@ -48,7 +47,7 @@ namespace osu.Game.Screens.Select.Carousel
// it's important we do the deselection after removing, so any further actions based on
// State.ValueChanged make decisions post-removal.
if (i.State.Value == CarouselItemState.Selected) i.State.Value = CarouselItemState.NotSelected;
i.State.Value = CarouselItemState.Collapsed;
}
protected CarouselItem()