diff --git a/osu-framework b/osu-framework
index dd9faf4609..059520c918 160000
--- a/osu-framework
+++ b/osu-framework
@@ -1 +1 @@
-Subproject commit dd9faf46095a761558abc6cb11ecd0e7498dba4e
+Subproject commit 059520c91803855835c734bb6d9b56e90238fe78
diff --git a/osu.Game/Beatmaps/Drawable/Panel.cs b/osu.Game/Beatmaps/Drawable/Panel.cs
index d2b1793b30..98b7cc4e97 100644
--- a/osu.Game/Beatmaps/Drawable/Panel.cs
+++ b/osu.Game/Beatmaps/Drawable/Panel.cs
@@ -52,7 +52,7 @@ namespace osu.Game.Beatmaps.Drawable
protected virtual void Selected()
{
- BorderColour = new Color4(BorderColour.R, BorderColour.G, BorderColour.B, 255);
+ BorderColour = new Color4(BorderColour.R, BorderColour.G, BorderColour.B, 1f);
BorderThickness = 2.5f;
EdgeEffect = new EdgeEffect
diff --git a/osu.Game/GameModes/Play/Catch/CatchComboCounter.cs b/osu.Game/GameModes/Play/Catch/CatchComboCounter.cs
index dc87e65eec..cf6f153ea1 100644
--- a/osu.Game/GameModes/Play/Catch/CatchComboCounter.cs
+++ b/osu.Game/GameModes/Play/Catch/CatchComboCounter.cs
@@ -19,7 +19,7 @@ namespace osu.Game.GameModes.Play.Catch
protected override bool CanPopOutWhileRolling => true;
protected virtual double FadeOutDelay => 1000;
- protected virtual double FadeOutDuration => 300;
+ protected override double FadeOutDuration => 300;
protected override string FormatCount(ulong count)
{
diff --git a/osu.Game/GameModes/Play/ComboCounter.cs b/osu.Game/GameModes/Play/ComboCounter.cs
index ebc89c102e..ffeed048f0 100644
--- a/osu.Game/GameModes/Play/ComboCounter.cs
+++ b/osu.Game/GameModes/Play/ComboCounter.cs
@@ -31,6 +31,8 @@ namespace osu.Game.GameModes.Play
protected virtual EasingTypes PopOutEasing => EasingTypes.None;
protected virtual float PopOutInitialAlpha => 0.75f;
+ protected virtual double FadeOutDuration => 100;
+
///
/// Duration in milliseconds for the counter roll-up animation for each element.
///
@@ -60,7 +62,6 @@ namespace osu.Game.GameModes.Play
}
}
- protected ulong prevCount;
protected ulong count;
///
@@ -204,7 +205,7 @@ namespace osu.Game.GameModes.Play
private void updateCount(ulong value, bool rolling = false)
{
- prevCount = count;
+ ulong prevCount = count;
count = value;
if (!rolling)
{
diff --git a/osu.Game/GameModes/Play/Osu/OsuComboCounter.cs b/osu.Game/GameModes/Play/Osu/OsuComboCounter.cs
index 253d1c7f8e..c1f76b2632 100644
--- a/osu.Game/GameModes/Play/Osu/OsuComboCounter.cs
+++ b/osu.Game/GameModes/Play/Osu/OsuComboCounter.cs
@@ -92,6 +92,11 @@ namespace osu.Game.GameModes.Play.Osu
protected override void OnCountRolling(ulong currentValue, ulong newValue)
{
ScheduledPopOutCurrentId++;
+
+ // Hides displayed count if was increasing from 0 to 1 but didn't finish
+ if (currentValue == 0 && newValue == 0)
+ DisplayedCountSpriteText.FadeOut(FadeOutDuration);
+
base.OnCountRolling(currentValue, newValue);
}
@@ -116,13 +121,17 @@ namespace osu.Game.GameModes.Play.Osu
protected override void OnCountChange(ulong currentValue, ulong newValue)
{
ScheduledPopOutCurrentId++;
+
+ if (newValue == 0)
+ DisplayedCountSpriteText.FadeOut();
+
base.OnCountChange(currentValue, newValue);
}
protected override void OnDisplayedCountRolling(ulong currentValue, ulong newValue)
{
if (newValue == 0)
- DisplayedCountSpriteText.FadeOut(PopOutDuration);
+ DisplayedCountSpriteText.FadeOut(FadeOutDuration);
else
DisplayedCountSpriteText.Show();
diff --git a/osu.Game/GameModes/Play/PlaySongSelect.cs b/osu.Game/GameModes/Play/PlaySongSelect.cs
index 309cd3119b..b7f61f9f8a 100644
--- a/osu.Game/GameModes/Play/PlaySongSelect.cs
+++ b/osu.Game/GameModes/Play/PlaySongSelect.cs
@@ -35,6 +35,7 @@ namespace osu.Game.GameModes.Play
private ScrollContainer scrollContainer;
private FlowContainer beatmapSetFlow;
private TrackManager trackManager;
+ private Container wedgeContainer;
/// Optionally provide a database to use instead of the OsuGame one.
public PlaySongSelect(BeatmapDatabase database = null)
@@ -45,7 +46,7 @@ namespace osu.Game.GameModes.Play
const float bottomToolHeight = 50;
Children = new Drawable[]
{
- new Container
+ wedgeContainer = new Container
{
RelativeSizeAxes = Axes.Both,
Size = Vector2.One,
@@ -147,6 +148,7 @@ namespace osu.Game.GameModes.Play
{
base.OnEntering(last);
ensurePlayingSelected();
+ wedgeContainer.FadeInFromZero(250);
}
protected override void OnResuming(GameMode last)
diff --git a/osu.Game/GameModes/Play/Taiko/TaikoComboCounter.cs b/osu.Game/GameModes/Play/Taiko/TaikoComboCounter.cs
index bd12d35315..70afd31988 100644
--- a/osu.Game/GameModes/Play/Taiko/TaikoComboCounter.cs
+++ b/osu.Game/GameModes/Play/Taiko/TaikoComboCounter.cs
@@ -43,7 +43,7 @@ namespace osu.Game.GameModes.Play.Taiko
protected override void OnDisplayedCountRolling(ulong currentValue, ulong newValue)
{
if (newValue == 0)
- DisplayedCountSpriteText.FadeOut(AnimationDuration);
+ DisplayedCountSpriteText.FadeOut(FadeOutDuration);
else
DisplayedCountSpriteText.Show();