sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-07-03 01:09:57 +09:00
Code Issues Packages Projects Releases Wiki Activity

Revert disallowing imports with no files

Browse Source 
While it is logical that we want this, from a testing perspective this is a bit of a nightmare to fix. Let's revisit at a later point in time.
This commit is contained in:
Dean Herbert
2021-10-21 13:35:26 +09:00
parent 7a1be99999
commit 59b7210efa
3 changed files with 28 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
osu.Game.Tests/Skins/IO/ImportSkinTest.cs
View File

@ -48,11 +48,12 @@ namespace osu.Game.Tests.Skins.IO
});
[Test]
public Task TestEmptyImportFails() => runSkinTest(osu =>
public Task TestEmptyImportImportsWithFilename() => runSkinTest(async osu =>
{
Assert.ThrowsAsync<InvalidOperationException>(() => loadSkinIntoOsu(osu, new ZipArchiveReader(createEmptyOsk(), "test skin.osk")));
var import1 = await loadSkinIntoOsu(osu, new ZipArchiveReader(createEmptyOsk(), "test skin.osk"));
return Task.CompletedTask;
// When the import filename matches it shouldn't be appended.
assertCorrectMetadata(import1, "test skin", "Unknown", osu);
});
#endregion