sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-03 06:36:31 +09:00
Code Issues Packages Projects Releases Wiki Activity

requested changes

Browse Source 
use IEquatable<T> instead of overriding Equals and `==` operator for primitive types.
This commit is contained in:
Unknown
2017-11-25 15:05:59 +01:00
parent e3a230320a
commit 5da1466e28
1 changed files with 16 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
osu.Game/Beatmaps/BeatmapMetadata.cs
View File

@ -1,6 +1,7 @@
// Copyright (c) 2007-2017 ppy Pty Ltd <contact@ppy.sh>.
// Licensed under the MIT Licence - https://raw.githubusercontent.com/ppy/osu/master/LICENCE
using System;
using System.Collections.Generic;
using System.ComponentModel.DataAnnotations.Schema;
using System.Linq;
@ -9,7 +10,7 @@ using osu.Game.Users;
namespace osu.Game.Beatmaps
{
public class BeatmapMetadata
public class BeatmapMetadata : IEquatable<BeatmapMetadata>
{
[DatabaseGenerated(DatabaseGeneratedOption.Identity)]
public int ID { get; set; }
@ -67,22 +68,22 @@ namespace osu.Game.Beatmaps
Tags
}.Where(s => !string.IsNullOrEmpty(s)).ToArray();
public override bool Equals(object other)
public bool Equals(BeatmapMetadata other)
{
var otherMetadata = other as BeatmapMetadata;
if (otherMetadata == null) return false;
if (other == null)
return false;
return (onlineBeatmapSetID?.Equals(otherMetadata.onlineBeatmapSetID) ?? false)
&& (Title?.Equals(otherMetadata.Title) ?? false)
&& (TitleUnicode?.Equals(otherMetadata.TitleUnicode) ?? false)
&& (Artist?.Equals(otherMetadata.Artist) ?? false)
&& (ArtistUnicode?.Equals(otherMetadata.ArtistUnicode) ?? false)
&& (AuthorString?.Equals(otherMetadata.AuthorString) ?? false)
&& (Source?.Equals(otherMetadata.Source) ?? false)
&& (Tags?.Equals(otherMetadata.Tags) ?? false)
&& PreviewTime.Equals(otherMetadata.PreviewTime)
&& (AudioFile?.Equals(otherMetadata.AudioFile) ?? false)
&& (BackgroundFile?.Equals(otherMetadata.BackgroundFile) ?? false);
return onlineBeatmapSetID == other.onlineBeatmapSetID
&& (Title?.Equals(other.Title) ?? false)
&& (TitleUnicode?.Equals(other.TitleUnicode) ?? false)
&& (Artist?.Equals(other.Artist) ?? false)
&& (ArtistUnicode?.Equals(other.ArtistUnicode) ?? false)
&& (AuthorString?.Equals(other.AuthorString) ?? false)
&& (Source?.Equals(other.Source) ?? false)
&& (Tags?.Equals(other.Tags) ?? false)
&& PreviewTime == other.PreviewTime
&& (AudioFile?.Equals(other.AudioFile) ?? false)
&& (BackgroundFile?.Equals(other.BackgroundFile) ?? false);
}
}
}