sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-04 07:06:35 +09:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #11551 from smoogipoo/fix-leave-room-race-2

Browse Source 
Fix client potentially not leaving a room on exiting multiplayer
This commit is contained in:
Dean Herbert
2021-02-08 19:23:14 +09:00
committed by GitHub
parent 115ad4c745 dbea6d4cee
commit 5fbed05d04
9 changed files with 332 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
osu.Game/Tests/Visual/Multiplayer/MultiplayerTestScene.cs
View File

@ -50,5 +50,13 @@ namespace osu.Game.Tests.Visual.Multiplayer
if (joinRoom)
RoomManager.Schedule(() => RoomManager.CreateRoom(Room));
});
public override void SetUpSteps()
{
base.SetUpSteps();
if (joinRoom)
AddUntilStep("wait for room join", () => Client.Room != null);
}
}
}

2
osu.Game/Tests/Visual/Multiplayer/TestMultiplayerClient.cs
View File

@ -100,6 +100,8 @@ namespace osu.Game.Tests.Visual.Multiplayer
return Task.FromResult(room);
}
protected override Task LeaveRoomInternal() => Task.CompletedTask;
public override Task TransferHost(int userId) => ((IMultiplayerClient)this).HostChanged(userId);
public override async Task ChangeSettings(MultiplayerRoomSettings settings)