From 5ff452cc9aa8e47be3a36a15facd7e148bb820dc Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Mon, 6 Dec 2021 12:29:11 +0900
Subject: [PATCH] Update success bool to access `Exception` to stop exceptions
 from firing outwards

---
 osu.Game/Online/Multiplayer/MultiplayerClient.cs | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/osu.Game/Online/Multiplayer/MultiplayerClient.cs b/osu.Game/Online/Multiplayer/MultiplayerClient.cs
index f8a25e0388..2ddcc09e1b 100644
--- a/osu.Game/Online/Multiplayer/MultiplayerClient.cs
+++ b/osu.Game/Online/Multiplayer/MultiplayerClient.cs
@@ -458,7 +458,8 @@ namespace osu.Game.Online.Multiplayer
                 {
                     GetAPIBeatmap(playlistItem.BeatmapID).ContinueWith(b =>
                     {
-                        bool success = b.IsCompletedSuccessfully;
+                        // Should be called outside of the `Scheduler` logic (and specifically accessing `Exception`) to suppress an exception from firing outwards.
+                        bool success = b.Exception == null;
 
                         Scheduler.Add(() =>
                         {