sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-08 00:53:56 +09:00
Code Issues Packages Projects Releases Wiki Activity

Increase RingExplosion base size for finishers.

Browse Source 
Subtle but looks good imo (checked with flyte).
This commit is contained in:
smoogipooo
2017-03-21 17:49:22 +09:00
parent eec4a1b5d3
commit 60e866aebd
3 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
osu.Desktop.VisualTests/Tests/TestCaseTaikoPlayfield.cs
View File

@ -41,7 +41,8 @@ namespace osu.Desktop.VisualTests.Tests
Result = HitResult.Hit, Result = HitResult.Hit,
Score = score, Score = score,
TimeOffset = 0, TimeOffset = 0,
ComboAtHit = 1 ComboAtHit = 1,
SecondHit = RNG.Next(2) == 0
} }
}); });
} }

7
osu.Game.Modes.Taiko/UI/RingExplosion.cs
View File

@ -16,7 +16,7 @@ namespace osu.Game.Modes.Taiko.UI
{ {
internal class RingExplosion : CircularContainer internal class RingExplosion : CircularContainer
{ {
public TaikoScoreResult ScoreResult; public TaikoJudgementInfo Judgement;
private Box innerFill; private Box innerFill;
@ -46,7 +46,10 @@ namespace osu.Game.Modes.Taiko.UI
[BackgroundDependencyLoader] [BackgroundDependencyLoader]
private void load(OsuColour colours) private void load(OsuColour colours)
{ {
switch (ScoreResult) if (Judgement.SecondHit)
Size *= 1.5f;
switch (Judgement.Score)
{ {
case TaikoScoreResult.Good: case TaikoScoreResult.Good:
innerFill.Colour = colours.Green; innerFill.Colour = colours.Green;

2
osu.Game.Modes.Taiko/UI/TaikoPlayfield.cs
View File

@ -202,7 +202,7 @@ namespace osu.Game.Modes.Taiko.UI
{ {
ringExplosionContainer.Add(new RingExplosion ringExplosionContainer.Add(new RingExplosion
{ {
ScoreResult = judgedObject.Judgement.Score Judgement = judgedObject.Judgement
}); });
} }