sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-07-01 16:29:58 +09:00
Code Issues Packages Projects Releases Wiki Activity

Move default state steps to SetUp rather than duplicating per test case

Browse Source
This commit is contained in:
Salman Ahmed
2022-07-15 22:09:54 +03:00
parent 8f7b3cf11a
commit 68afb65aff
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
osu.Game.Tests/Visual/Gameplay/TestScenePlayerLocalScoreImport.cs
View File

@ -66,11 +66,17 @@ namespace osu.Game.Tests.Visual.Gameplay
private bool allowFail; private bool allowFail;
[SetUp]
public void SetUp()
{
allowFail = false;
customRuleset = null;
}
[Test] [Test]
public void TestSaveFailedReplay() public void TestSaveFailedReplay()
{ {
AddStep("set fail", () => allowFail = true); AddStep("allow fail", () => allowFail = true);
AddStep("set no custom ruleset", () => customRuleset = null);
CreateTest(); CreateTest();
@ -85,8 +91,6 @@ namespace osu.Game.Tests.Visual.Gameplay
{ {
DateTimeOffset? getLastPlayed() => Realm.Run(r => r.Find<BeatmapInfo>(Beatmap.Value.BeatmapInfo.ID)?.LastPlayed); DateTimeOffset? getLastPlayed() => Realm.Run(r => r.Find<BeatmapInfo>(Beatmap.Value.BeatmapInfo.ID)?.LastPlayed);
AddStep("set no fail", () => allowFail = false);
AddStep("set no custom ruleset", () => customRuleset = null);
AddAssert("last played is null", () => getLastPlayed() == null); AddAssert("last played is null", () => getLastPlayed() == null);
CreateTest(); CreateTest();
@ -98,9 +102,6 @@ namespace osu.Game.Tests.Visual.Gameplay
[Test] [Test]
public void TestScoreStoredLocally() public void TestScoreStoredLocally()
{ {
AddStep("set no fail", () => allowFail = false);
AddStep("set no custom ruleset", () => customRuleset = null);
CreateTest(); CreateTest();
AddUntilStep("wait for track to start running", () => Beatmap.Value.Track.IsRunning); AddUntilStep("wait for track to start running", () => Beatmap.Value.Track.IsRunning);
@ -116,7 +117,6 @@ namespace osu.Game.Tests.Visual.Gameplay
{ {
Ruleset createCustomRuleset() => new CustomRuleset(); Ruleset createCustomRuleset() => new CustomRuleset();
AddStep("set no fail", () => allowFail = false);
AddStep("import custom ruleset", () => Realm.Write(r => r.Add(createCustomRuleset().RulesetInfo))); AddStep("import custom ruleset", () => Realm.Write(r => r.Add(createCustomRuleset().RulesetInfo)));
AddStep("set custom ruleset", () => customRuleset = createCustomRuleset()); AddStep("set custom ruleset", () => customRuleset = createCustomRuleset());