Refactor mod panel selection logic to avoid overwriting

This commit is contained in:
Bartłomiej Dach
2022-08-16 22:41:32 +02:00
parent a494e55d93
commit 6bfdfeb153
3 changed files with 35 additions and 21 deletions

View File

@ -37,8 +37,6 @@ namespace osu.Game.Overlays.Mods
Shear = new Vector2(-ShearedOverlayContainer.SHEAR, 0),
Scale = new Vector2(HEIGHT / ModSwitchSmall.DEFAULT_SIZE)
};
Action = select;
}
public ModPanel(Mod mod)
@ -59,18 +57,16 @@ namespace osu.Game.Overlays.Mods
Filtered.BindValueChanged(_ => updateFilterState(), true);
}
private void select()
protected override void Select()
{
if (!Active.Value)
{
modState.RequiresConfiguration = Mod.RequiresConfiguration;
Active.Value = true;
}
else
{
modState.RequiresConfiguration = false;
Active.Value = false;
}
modState.RequiresConfiguration = Mod.RequiresConfiguration;
Active.Value = true;
}
protected override void Deselect()
{
modState.RequiresConfiguration = false;
Active.Value = false;
}
#region Filtering support