sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-03 14:46:38 +09:00
Code Issues Packages Projects Releases Wiki Activity

apply feedback

Browse Source 
-don't directly set AllowOverlay Bindable
this should be done specifically where needed
-remove AllowOverlay Bindable from ButtonSystem
-remove unnecessary xmldoc
This commit is contained in:
Aergwyn
2018-06-03 11:30:58 +02:00
parent 6000a90721
commit 707af02097
7 changed files with 10 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
osu.Game/Screens/OsuScreen.cs
View File

@ -54,11 +54,12 @@ namespace osu.Game.Screens
/// </summary>
protected virtual bool HideOverlaysOnEnter => false;
private readonly Bindable<OverlayActivation> allowOverlays = new Bindable<OverlayActivation>();
/// <summary>
/// Whether overlays should be able to be opened.
/// It's bound at load which means changes at construction will potentially disappear.
/// Whether overlays should be able to be opened once this screen is entered or resumed.
/// </summary>
protected readonly Bindable<OverlayActivation> AllowOverlays = new Bindable<OverlayActivation>();
protected virtual OverlayActivation OverlayActivationLevel => OverlayActivation.All;
/// <summary>
/// Whether this <see cref="OsuScreen"/> allows the cursor to be displayed.
@ -109,7 +110,7 @@ namespace osu.Game.Screens
if (osuGame != null)
{
Ruleset.BindTo(osuGame.Ruleset);
AllowOverlays.BindTo(osuGame.AllowOverlays);
allowOverlays.BindTo(osuGame.AllowOverlays);
updateOverlayStates = () =>
{
@ -252,6 +253,8 @@ namespace osu.Game.Screens
if (backgroundParallaxContainer != null)
backgroundParallaxContainer.ParallaxAmount = ParallaxContainer.DEFAULT_PARALLAX_AMOUNT * BackgroundParallaxAmount;
allowOverlays.Value = OverlayActivationLevel;
updateOverlayStates?.Invoke();
}