From 70a120ea8a5e7694c068624b6495fa857f95a4e8 Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Sun, 23 Jan 2022 18:00:24 +0900
Subject: [PATCH] Add missing lock coverage when using `subscriptionActions`
 dictionary

---
 osu.Game/Database/RealmContextFactory.cs | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/osu.Game/Database/RealmContextFactory.cs b/osu.Game/Database/RealmContextFactory.cs
index 6fb9a2996b..606871337c 100644
--- a/osu.Game/Database/RealmContextFactory.cs
+++ b/osu.Game/Database/RealmContextFactory.cs
@@ -249,11 +249,13 @@ namespace osu.Game.Database
 
             return new InvokeOnDisposal(() =>
             {
-                // TODO: this likely needs to be run on the update thread.
-                if (subscriptionActions.TryGetValue(action, out var unsubscriptionAction))
+                lock (contextLock)
                 {
-                    unsubscriptionAction?.Dispose();
-                    subscriptionActions.Remove(action);
+                    if (subscriptionActions.TryGetValue(action, out var unsubscriptionAction))
+                    {
+                        unsubscriptionAction?.Dispose();
+                        subscriptionActions.Remove(action);
+                    }
                 }
             });
         }