sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-08 00:53:56 +09:00
Code Issues Packages Projects Releases Wiki Activity

Rename AllowSampleLookup argument to something saner

Browse Source
This commit is contained in:
Bartłomiej Dach
2021-12-26 14:29:07 +01:00
parent dc21c8901e
commit 724b601d2a
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Game/Skinning/BeatmapSkinProvidingContainer.cs
View File

@ -57,12 +57,12 @@ namespace osu.Game.Skinning
return beatmapSkins.Value; return beatmapSkins.Value;
} }
protected override bool AllowSampleLookup(ISampleInfo componentName) protected override bool AllowSampleLookup(ISampleInfo sampleInfo)
{ {
if (beatmapSkins == null) if (beatmapSkins == null)
throw new InvalidOperationException($"{nameof(BeatmapSkinProvidingContainer)} needs to be loaded before being consumed."); throw new InvalidOperationException($"{nameof(BeatmapSkinProvidingContainer)} needs to be loaded before being consumed.");
return componentName is StoryboardSampleInfo || beatmapHitsounds.Value; return sampleInfo is StoryboardSampleInfo || beatmapHitsounds.Value;
} }
public BeatmapSkinProvidingContainer(ISkin skin) public BeatmapSkinProvidingContainer(ISkin skin)

2
osu.Game/Skinning/SkinProvidingContainer.cs
View File

@ -35,7 +35,7 @@ namespace osu.Game.Skinning
protected virtual bool AllowTextureLookup(string componentName) => true; protected virtual bool AllowTextureLookup(string componentName) => true;
protected virtual bool AllowSampleLookup(ISampleInfo componentName) => true; protected virtual bool AllowSampleLookup(ISampleInfo sampleInfo) => true;
protected virtual bool AllowConfigurationLookup => true; protected virtual bool AllowConfigurationLookup => true;