sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-04 23:24:04 +09:00
Code Issues Packages Projects Releases Wiki Activity

Apply review suggestions

Browse Source
This commit is contained in:
Endrik Tombak
2020-11-21 14:26:09 +02:00
parent 6c5a6b42e5
commit 72d9da5fac
2 changed files with 18 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
osu.Game/Screens/Select/DifficultyRecommender.cs
View File

@ -81,7 +81,6 @@ namespace osu.Game.Screens.Select
req.Success += result =>
{
bestRulesetOrder = null;
// algorithm taken from https://github.com/ppy/osu-web/blob/e6e2825516449e3d0f3f5e1852c6bdd3428c3437/app/Models/User.php#L1505
recommendedStarDifficulty[rulesetInfo] = Math.Pow((double)(result.Statistics.PP ?? 0), 0.4) * 0.195;
};
@ -90,19 +89,12 @@ namespace osu.Game.Screens.Select
});
}
private IEnumerable<RulesetInfo> bestRulesetOrder;
private IEnumerable<RulesetInfo> getBestRulesetOrder()
{
bestRulesetOrder ??= recommendedStarDifficulty.OrderByDescending(pair => pair.Value)
.Select(pair => pair.Key)
.ToList();
IEnumerable<RulesetInfo> bestRulesetOrder = recommendedStarDifficulty.OrderByDescending(pair => pair.Value)
.Select(pair => pair.Key)
.ToList();
return moveCurrentRulesetToFirst();
}
private IEnumerable<RulesetInfo> moveCurrentRulesetToFirst()
{
List<RulesetInfo> orderedRulesets;
if (bestRulesetOrder.Contains(ruleset.Value))