sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-07-01 08:20:00 +09:00
Code Issues Packages Projects Releases Wiki Activity

Extract external link opening to the ExternalLinkOpener class

Browse Source
This commit is contained in:
Roman Kapustin
2018-10-23 23:03:00 +03:00
parent 805f8d98c4
commit 7401fabb5d
3 changed files with 46 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
osu.Game/Graphics/Containers/LinkFlowContainer.cs
View File

@ -7,11 +7,7 @@ using System.Linq;
using osu.Framework.Allocation;
using osu.Framework.Graphics.Sprites;
using System.Collections.Generic;
using osu.Framework.Configuration;
using osu.Framework.Platform;
using osu.Game.Configuration;
using osu.Game.Overlays;
using osu.Game.Overlays.Chat;
using osu.Game.Overlays.Notifications;
namespace osu.Game.Graphics.Containers
@ -26,20 +22,12 @@ namespace osu.Game.Graphics.Containers
private OsuGame game;
private Action showNotImplementedError;
private GameHost host;
private DialogOverlay dialogOverlay;
private Bindable<bool> warnAboutOpeningExternal;
[BackgroundDependencyLoader(true)]
private void load(OsuGame game, NotificationOverlay notifications, GameHost host, DialogOverlay dialogOverlay, OsuConfigManager config)
private void load(OsuGame game, NotificationOverlay notifications)
{
// will be null in tests
this.game = game;
this.host = host;
this.dialogOverlay = dialogOverlay;
warnAboutOpeningExternal = config.GetBindable<bool>(OsuSetting.WarnAboutOpeningExternalLink);
showNotImplementedError = () => notifications?.Post(new SimpleNotification
{
@ -97,11 +85,7 @@ namespace osu.Game.Graphics.Containers
showNotImplementedError?.Invoke();
break;
case LinkAction.External:
void externalAction() => host.OpenUrlExternally(url);
if (warnAboutOpeningExternal)
dialogOverlay.Push(new ExternalLinkDialog(url, externalAction));
else
externalAction();
game?.OpenUrlExternally(url);
break;
case LinkAction.OpenUserProfile:
if (long.TryParse(linkArgument, out long userId))