sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-07-01 16:29:58 +09:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary hack (fixed via framework update)

Browse Source
This commit is contained in:
Dean Herbert
2020-10-13 19:17:23 +09:00
parent 5d11db7753
commit 75b6a5e17e
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
osu.Game/Screens/Select/Carousel/DrawableCarouselBeatmapSet.cs
View File

@ -113,9 +113,7 @@ namespace osu.Game.Screens.Select.Carousel
{ {
var carouselBeatmapSet = (CarouselBeatmapSet)Item; var carouselBeatmapSet = (CarouselBeatmapSet)Item;
var visibleBeatmaps = carouselBeatmapSet.Children var visibleBeatmaps = carouselBeatmapSet.Children.Where(c => c.Visible).ToArray();
.Where(c => c.Visible)
.ToArray();
// if we are already displaying all the correct beatmaps, only run animation updates. // if we are already displaying all the correct beatmaps, only run animation updates.
// note that the displayed beatmaps may change due to the applied filter. // note that the displayed beatmaps may change due to the applied filter.
@ -129,13 +127,11 @@ namespace osu.Game.Screens.Select.Carousel
// on selection we show our child beatmaps. // on selection we show our child beatmaps.
// for now this is a simple drawable construction each selection. // for now this is a simple drawable construction each selection.
// can be improved in the future. // can be improved in the future.
beatmapContainer = new Container<DrawableCarouselItem> beatmapContainer = new Container<DrawableCarouselItem>
{ {
X = 100, X = 100,
RelativeSizeAxes = Axes.Both, RelativeSizeAxes = Axes.Both,
// ToArray() in this line is required due to framework oversight: https://github.com/ppy/osu-framework/pull/3929 ChildrenEnumerable = visibleBeatmaps.Select(c => c.CreateDrawableRepresentation())
ChildrenEnumerable = visibleBeatmaps.Select(c => c.CreateDrawableRepresentation()).ToArray()
}; };
LoadComponentAsync(beatmapContainer, loaded => LoadComponentAsync(beatmapContainer, loaded =>