sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-04 07:06:35 +09:00
Code Issues Packages Projects Releases Wiki Activity

Limit shake duration to ensure it doesn't overlap miss window

Browse Source
This commit is contained in:
Dean Herbert
2018-07-06 17:24:30 +09:00
parent 98410dbb6d
commit 79af5cb0a0
4 changed files with 20 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game.Rulesets.Osu/Objects/Drawables/DrawableHitCircle.cs
View File

@ -89,7 +89,7 @@ namespace osu.Game.Rulesets.Osu.Objects.Drawables
var result = HitObject.HitWindows.ResultFor(timeOffset);
if (result == HitResult.None)
{
Shake();
Shake(Math.Abs(timeOffset) - HitObject.HitWindows.HalfWindowFor(HitResult.Miss));
return;
}

2
osu.Game.Rulesets.Osu/Objects/Drawables/DrawableOsuHitObject.cs
View File

@ -69,7 +69,7 @@ namespace osu.Game.Rulesets.Osu.Objects.Drawables
private OsuInputManager osuActionInputManager;
internal OsuInputManager OsuActionInputManager => osuActionInputManager ?? (osuActionInputManager = GetContainingInputManager() as OsuInputManager);
protected virtual void Shake() => shakeContainer.Shake();
protected virtual void Shake(double maximumLength) => shakeContainer.Shake(maximumLength);
}
public enum ComboResult

4
osu.Game.Rulesets.Osu/Objects/Drawables/DrawableSliderHead.cs
View File

@ -30,8 +30,8 @@ namespace osu.Game.Rulesets.Osu.Objects.Drawables
Position = slider.CurvePositionAt(completionProgress);
}
public Action OnShake;
public Action<double> OnShake;
protected override void Shake() => OnShake?.Invoke();
protected override void Shake(double maximumLength) => OnShake?.Invoke(maximumLength);
}
}