sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-06 16:13:57 +09:00
Code Issues Packages Projects Releases Wiki Activity

Add test coverage of ruleset being marked unavailable if methods are throwing

Browse Source
This commit is contained in:
Dean Herbert
2022-08-29 14:28:55 +09:00
parent 5ff4e6a4fe
commit 892f43da43
1 changed files with 30 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
osu.Game.Tests/Database/RulesetStoreTests.cs
View File

@ -60,15 +60,40 @@ namespace osu.Game.Tests.Database
}); });
} }
[Test]
public void TestRulesetThrowingOnMethods()
{
RunTestWithRealm((realm, storage) =>
{
LoadTestRuleset.Version = Ruleset.CURRENT_RULESET_API_VERSION;
LoadTestRuleset.HasImplementations = false;
var ruleset = new LoadTestRuleset();
string rulesetShortName = ruleset.RulesetInfo.ShortName;
realm.Write(r => r.Add(new RulesetInfo(rulesetShortName, ruleset.RulesetInfo.Name, ruleset.RulesetInfo.InstantiationInfo, ruleset.RulesetInfo.OnlineID)
{
Available = true,
}));
Assert.That(realm.Run(r => r.Find<RulesetInfo>(rulesetShortName).Available), Is.True);
// Availability is updated on construction of a RealmRulesetStore
var _ = new RealmRulesetStore(realm, storage);
Assert.That(realm.Run(r => r.Find<RulesetInfo>(rulesetShortName).Available), Is.False);
});
}
[Test] [Test]
public void TestOutdatedRulesetNotAvailable() public void TestOutdatedRulesetNotAvailable()
{ {
RunTestWithRealm((realm, storage) => RunTestWithRealm((realm, storage) =>
{ {
OutdatedRuleset.Version = "2021.101.0"; LoadTestRuleset.Version = "2021.101.0";
OutdatedRuleset.HasImplementations = true; LoadTestRuleset.HasImplementations = true;
var ruleset = new OutdatedRuleset(); var ruleset = new LoadTestRuleset();
string rulesetShortName = ruleset.RulesetInfo.ShortName; string rulesetShortName = ruleset.RulesetInfo.ShortName;
realm.Write(r => r.Add(new RulesetInfo(rulesetShortName, ruleset.RulesetInfo.Name, ruleset.RulesetInfo.InstantiationInfo, ruleset.RulesetInfo.OnlineID) realm.Write(r => r.Add(new RulesetInfo(rulesetShortName, ruleset.RulesetInfo.Name, ruleset.RulesetInfo.InstantiationInfo, ruleset.RulesetInfo.OnlineID)
@ -84,14 +109,14 @@ namespace osu.Game.Tests.Database
Assert.That(realm.Run(r => r.Find<RulesetInfo>(rulesetShortName).Available), Is.False); Assert.That(realm.Run(r => r.Find<RulesetInfo>(rulesetShortName).Available), Is.False);
// Simulate the ruleset getting updated // Simulate the ruleset getting updated
OutdatedRuleset.Version = Ruleset.CURRENT_RULESET_API_VERSION; LoadTestRuleset.Version = Ruleset.CURRENT_RULESET_API_VERSION;
var __ = new RealmRulesetStore(realm, storage); var __ = new RealmRulesetStore(realm, storage);
Assert.That(realm.Run(r => r.Find<RulesetInfo>(rulesetShortName).Available), Is.True); Assert.That(realm.Run(r => r.Find<RulesetInfo>(rulesetShortName).Available), Is.True);
}); });
} }
private class OutdatedRuleset : Ruleset private class LoadTestRuleset : Ruleset
{ {
public override string RulesetAPIVersionSupported => Version; public override string RulesetAPIVersionSupported => Version;