sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-07-01 16:29:58 +09:00
Code Issues Packages Projects Releases Wiki Activity

Fix visual tests missing dependency for ColourCodedNotes

Browse Source
This commit is contained in:
Justus Franklin Tumacder
2021-04-24 21:07:17 +08:00
parent 3103fd8343
commit 8b01082cbb
7 changed files with 69 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
osu.Game.Rulesets.Mania/Objects/Drawables/DrawableNote.cs
View File

@ -26,9 +26,9 @@ namespace osu.Game.Rulesets.Mania.Objects.Drawables
private OsuColour colours { get; set; }
[Resolved]
private Bindable<bool> configColourCode { get; set; }
private Bindable<bool> configColourCodedNotes { get; set; }
[Resolved]
[Resolved(canBeNull: true)]
private SnapFinder snapFinder { get; set; }
protected virtual ManiaSkinComponents Component => ManiaSkinComponents.Note;
@ -60,10 +60,13 @@ namespace osu.Game.Rulesets.Mania.Objects.Drawables
{
base.LoadComplete();
HitObject.StartTimeBindable.BindValueChanged(_ => Snap = snapFinder.FindSnap(HitObject), true);
if (snapFinder != null)
{
HitObject.StartTimeBindable.BindValueChanged(_ => Snap = snapFinder.FindSnap(HitObject), true);
SnapBindable.BindValueChanged(snap => UpdateSnapColour(configColourCode.Value, snap.NewValue), true);
configColourCode.BindValueChanged(colourCode => UpdateSnapColour(colourCode.NewValue, Snap));
SnapBindable.BindValueChanged(snap => UpdateSnapColour(configColourCodedNotes.Value, snap.NewValue), true);
configColourCodedNotes.BindValueChanged(colourCode => UpdateSnapColour(colourCode.NewValue, Snap));
}
}
protected override void OnDirectionChanged(ValueChangedEvent<ScrollingDirection> e)