sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-06 16:13:57 +09:00
Code Issues Packages Projects Releases Wiki Activity

Test using a simple GetTexture lookup instead

Browse Source 
Presumes that `RulesetSkinProvidingContainer` doesn't allow falling back
to parent skins, whatsoever.
This commit is contained in:
Salman Ahmed
2021-06-25 10:55:23 +03:00
parent 06e357647a
commit 8d7705dc92
1 changed files with 5 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
osu.Game.Tests/Rulesets/TestSceneRulesetSkinProvidingContainer.cs
View File

@ -2,8 +2,6 @@
// See the LICENCE file in the repository root for full licence text. // See the LICENCE file in the repository root for full licence text.
using System; using System;
using System.Linq;
using JetBrains.Annotations;
using NUnit.Framework; using NUnit.Framework;
using osu.Framework.Allocation; using osu.Framework.Allocation;
using osu.Framework.Audio.Sample; using osu.Framework.Audio.Sample;
@ -12,7 +10,6 @@ using osu.Framework.Graphics;
using osu.Framework.Graphics.OpenGL.Textures; using osu.Framework.Graphics.OpenGL.Textures;
using osu.Framework.Graphics.Textures; using osu.Framework.Graphics.Textures;
using osu.Game.Audio; using osu.Game.Audio;
using osu.Game.Beatmaps;
using osu.Game.Rulesets; using osu.Game.Rulesets;
using osu.Game.Skinning; using osu.Game.Skinning;
using osu.Game.Tests.Testing; using osu.Game.Tests.Testing;
@ -27,15 +24,14 @@ namespace osu.Game.Tests.Rulesets
private SkinRequester requester; private SkinRequester requester;
protected override Ruleset CreateRuleset() => new TestRuleset(); protected override Ruleset CreateRuleset() => new TestSceneRulesetDependencies.TestRuleset();
[Test] [Test]
public void TestEarlyAddedSkinRequester() public void TestEarlyAddedSkinRequester()
{ {
ISample transformerSampleOnLoad = null; Texture textureOnLoad = null;
// need a legacy skin to plug the TestRuleset's legacy transformer, which is required for testing this. AddStep("set skin", () => skins.CurrentSkinInfo.Value = DefaultLegacySkin.Info);
AddStep("set legacy skin", () => skins.CurrentSkinInfo.Value = DefaultLegacySkin.Info);
AddStep("setup provider", () => AddStep("setup provider", () =>
{ {
@ -43,12 +39,12 @@ namespace osu.Game.Tests.Rulesets
rulesetSkinProvider.Add(requester = new SkinRequester()); rulesetSkinProvider.Add(requester = new SkinRequester());
requester.OnLoadAsync += () => transformerSampleOnLoad = requester.GetSample(new SampleInfo(TestLegacySkinTransformer.VIRTUAL_SAMPLE_NAME)); requester.OnLoadAsync += () => textureOnLoad = requester.GetTexture("hitcircle");
Child = rulesetSkinProvider; Child = rulesetSkinProvider;
}); });
AddAssert("requester got correct initial sample", () => transformerSampleOnLoad != null); AddAssert("requester got correct initial texture", () => textureOnLoad != null);
} }
private class SkinRequester : Drawable, ISkin private class SkinRequester : Drawable, ISkin
@ -73,28 +69,5 @@ namespace osu.Game.Tests.Rulesets
public IBindable<TValue> GetConfig<TLookup, TValue>(TLookup lookup) => skin.GetConfig<TLookup, TValue>(lookup); public IBindable<TValue> GetConfig<TLookup, TValue>(TLookup lookup) => skin.GetConfig<TLookup, TValue>(lookup);
} }
private class TestRuleset : TestSceneRulesetDependencies.TestRuleset
{
public override ISkin CreateLegacySkinProvider(ISkin skin, IBeatmap beatmap) => new TestLegacySkinTransformer(skin);
}
private class TestLegacySkinTransformer : LegacySkinTransformer
{
public const string VIRTUAL_SAMPLE_NAME = "virtual-test-sample";
public TestLegacySkinTransformer([NotNull] ISkin skin)
: base(skin)
{
}
public override ISample GetSample(ISampleInfo sampleInfo)
{
if (sampleInfo.LookupNames.Single() == VIRTUAL_SAMPLE_NAME)
return new SampleVirtual();
return base.GetSample(sampleInfo);
}
}
} }
} }