sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-06-05 12:57:39 +09:00
Code Issues Packages Projects Releases Wiki Activity

Mark CreateHitObjectComposer() accept null.

Browse Source 
And add the null check in the test case.
This commit is contained in:
為什麼 2022-07-10 10:09:32 +08:00
parent 57c6763556
commit 8e1ed1c621
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
osu.Game.Tests/Visual/Editing/TimelineTestScene.cs
View File

@ -39,7 +39,13 @@ namespace osu.Game.Tests.Visual.Editing
Dependencies.Cache(EditorBeatmap); Dependencies.Cache(EditorBeatmap);
Dependencies.CacheAs<IBeatSnapProvider>(EditorBeatmap); Dependencies.CacheAs<IBeatSnapProvider>(EditorBeatmap);
Composer = playable.BeatmapInfo.Ruleset.CreateInstance().CreateHitObjectComposer().With(d => d.Alpha = 0); Composer = playable.BeatmapInfo.Ruleset.CreateInstance().CreateHitObjectComposer().With(d =>
{
if (d == null)
return;
d.Alpha = 0;
});
Add(new OsuContextMenuContainer Add(new OsuContextMenuContainer
{ {

2
osu.Game/Rulesets/Ruleset.cs
View File

@ -236,7 +236,7 @@ namespace osu.Game.Rulesets
/// <returns>A performance calculator instance for the provided score.</returns> /// <returns>A performance calculator instance for the provided score.</returns>
public virtual PerformanceCalculator? CreatePerformanceCalculator() => null; public virtual PerformanceCalculator? CreatePerformanceCalculator() => null;
public virtual HitObjectComposer CreateHitObjectComposer() => null; public virtual HitObjectComposer? CreateHitObjectComposer() => null;
public virtual IBeatmapVerifier? CreateBeatmapVerifier() => null; public virtual IBeatmapVerifier? CreateBeatmapVerifier() => null;