sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-07 00:23:59 +09:00
Code Issues Packages Projects Releases Wiki Activity

Turn GenerateTicks into a bindable to pass code quality tests

Browse Source
This commit is contained in:
Khang
2022-08-22 22:43:44 -04:00
parent 9f08c474ca
commit 8f708c1dcf
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
osu.Game/Beatmaps/ControlPoints/DifficultyControlPoint.cs
View File

@ -16,6 +16,7 @@ namespace osu.Game.Beatmaps.ControlPoints
public static readonly DifficultyControlPoint DEFAULT = new DifficultyControlPoint public static readonly DifficultyControlPoint DEFAULT = new DifficultyControlPoint
{ {
SliderVelocityBindable = { Disabled = true }, SliderVelocityBindable = { Disabled = true },
GenerateTicksBindable = { Disabled = true },
}; };
/// <summary> /// <summary>
@ -29,6 +30,12 @@ namespace osu.Game.Beatmaps.ControlPoints
MaxValue = 10 MaxValue = 10
}; };
/// <summary>
/// Whether or not slider ticks should be generated at this control point.
/// This exists for backwards compatibility with maps that abuse NaN slider velocity behavior on osu!stable (e.g. /b/2628991).
/// </summary>
public readonly BindableBool GenerateTicksBindable = new BindableBool(true);
public override Color4 GetRepresentingColour(OsuColour colours) => colours.Lime1; public override Color4 GetRepresentingColour(OsuColour colours) => colours.Lime1;
/// <summary> /// <summary>
@ -44,7 +51,11 @@ namespace osu.Game.Beatmaps.ControlPoints
/// Whether or not slider ticks should be generated at this control point. /// Whether or not slider ticks should be generated at this control point.
/// This exists for backwards compatibility with maps that abuse NaN slider velocity behavior on osu!stable (e.g. /b/2628991). /// This exists for backwards compatibility with maps that abuse NaN slider velocity behavior on osu!stable (e.g. /b/2628991).
/// </summary> /// </summary>
public bool GenerateTicks { get; set; } = true; public bool GenerateTicks
{
get => GenerateTicksBindable.Value;
set => GenerateTicksBindable.Value = value;
}
public override bool IsRedundant(ControlPoint? existing) public override bool IsRedundant(ControlPoint? existing)
=> existing is DifficultyControlPoint existingDifficulty => existing is DifficultyControlPoint existingDifficulty