sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-02 06:07:11 +09:00
Code Issues Packages Projects Releases Wiki Activity

Take current mod settings value into account on equality comparsion

Browse Source
This commit is contained in:
Salman Ahmed
2021-04-12 20:10:22 +03:00
parent fbd5195738
commit 92fab653e1
2 changed files with 38 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
osu.Game/Rulesets/Mods/Mod.cs
View File

@ -12,6 +12,7 @@ using osu.Framework.Testing;
using osu.Game.Configuration;
using osu.Game.IO.Serialization;
using osu.Game.Rulesets.UI;
using osu.Game.Utils;
namespace osu.Game.Rulesets.Mods
{
@ -173,7 +174,18 @@ namespace osu.Game.Rulesets.Mods
}
public bool Equals(IMod other) => other is Mod them && Equals(them);
public bool Equals(Mod other) => GetType() == other?.GetType();
public bool Equals(Mod other)
{
if (ReferenceEquals(null, other)) return false;
if (ReferenceEquals(this, other)) return true;
return GetType() == other.GetType() &&
this.GetSettingsSourceProperties().All(pair =>
EqualityComparer<object>.Default.Equals(
ModUtils.GetSettingUnderlyingValue(pair.Item2.GetValue(this)),
ModUtils.GetSettingUnderlyingValue(pair.Item2.GetValue(other))));
}
/// <summary>
/// Reset all custom settings for this mod back to their defaults.