From 9565bb9572a80aeb4cf8ef32c23b92d4b583e3f7 Mon Sep 17 00:00:00 2001
From: smoogipooo <smoogipooo@gmail.com>
Date: Fri, 12 May 2017 19:10:26 +0900
Subject: [PATCH] Fix hold notes - remove glow for now.

# Conflicts:
#	osu.Game.Rulesets.Mania/Objects/Drawables/DrawableHoldNote.cs
#	osu.Game.Rulesets.Mania/Objects/Drawables/DrawableManiaHitObject.cs
---
 .../Tests/TestCaseManiaHitObjects.cs          | 14 +++-------
 .../Objects/Drawables/DrawableHoldNote.cs     | 11 ++++++++
 .../Drawables/DrawableManiaHitObject.cs       | 26 -------------------
 .../Objects/Drawables/Pieces/BodyPiece.cs     |  1 -
 .../Objects/Legacy/ConvertHitObjectParser.cs  |  5 ++--
 5 files changed, 17 insertions(+), 40 deletions(-)

diff --git a/osu.Desktop.VisualTests/Tests/TestCaseManiaHitObjects.cs b/osu.Desktop.VisualTests/Tests/TestCaseManiaHitObjects.cs
index 3ad83beb73..3113b63db1 100644
--- a/osu.Desktop.VisualTests/Tests/TestCaseManiaHitObjects.cs
+++ b/osu.Desktop.VisualTests/Tests/TestCaseManiaHitObjects.cs
@@ -43,13 +43,8 @@ namespace osu.Desktop.VisualTests.Tests
                                 RelativeCoordinateSpace = new Vector2(1, 10000),
                                 Children = new[]
                                 {
-                                    new DrawableNote(new Note
-                                    {
-                                        StartTime = 5000
-                                    })
-                                    {
-                                        AccentColour = Color4.Red
-                                    }
+                                    new DrawableNote(new Note { StartTime = 5000 }) { AccentColour = Color4.Red },
+                                    new DrawableNote(new Note { StartTime = 6000 }) { AccentColour = Color4.Red }
                                 }
                             }
                         }
@@ -74,10 +69,7 @@ namespace osu.Desktop.VisualTests.Tests
                                     {
                                         StartTime = 5000,
                                         Duration = 1000
-                                    })
-                                    {
-                                        AccentColour = Color4.Red
-                                    }
+                                    }) { AccentColour = Color4.Red }
                                 }
                             }
                         }
diff --git a/osu.Game.Rulesets.Mania/Objects/Drawables/DrawableHoldNote.cs b/osu.Game.Rulesets.Mania/Objects/Drawables/DrawableHoldNote.cs
index 767a2b3458..a1327a3105 100644
--- a/osu.Game.Rulesets.Mania/Objects/Drawables/DrawableHoldNote.cs
+++ b/osu.Game.Rulesets.Mania/Objects/Drawables/DrawableHoldNote.cs
@@ -61,5 +61,16 @@ namespace osu.Game.Rulesets.Mania.Objects.Drawables
         protected override void UpdateState(ArmedState state)
         {
         }
+
+        protected override void Update()
+        {
+            if (Time.Current > HitObject.StartTime)
+                headPiece.Colour = Color4.Green;
+            if (Time.Current > HitObject.EndTime)
+            {
+                bodyPiece.Colour = Color4.Green;
+                tailPiece.Colour = Color4.Green;
+            }
+        }
     }
 }
diff --git a/osu.Game.Rulesets.Mania/Objects/Drawables/DrawableManiaHitObject.cs b/osu.Game.Rulesets.Mania/Objects/Drawables/DrawableManiaHitObject.cs
index 0307e9162a..d33a8c48ee 100644
--- a/osu.Game.Rulesets.Mania/Objects/Drawables/DrawableManiaHitObject.cs
+++ b/osu.Game.Rulesets.Mania/Objects/Drawables/DrawableManiaHitObject.cs
@@ -3,8 +3,6 @@
 
 using OpenTK.Graphics;
 using osu.Framework.Graphics;
-using osu.Framework.Graphics.Containers;
-using osu.Framework.Graphics.Sprites;
 using osu.Game.Rulesets.Mania.Judgements;
 using osu.Game.Rulesets.Objects.Drawables;
 
@@ -15,8 +13,6 @@ namespace osu.Game.Rulesets.Mania.Objects.Drawables
     {
         public new TObject HitObject;
 
-        private readonly Container glowContainer;
-
         protected DrawableManiaHitObject(TObject hitObject)
             : base(hitObject)
         {
@@ -24,21 +20,6 @@ namespace osu.Game.Rulesets.Mania.Objects.Drawables
 
             RelativePositionAxes = Axes.Y;
             Y = (float)HitObject.StartTime;
-
-            Add(glowContainer = new Container
-            {
-                RelativeSizeAxes = Axes.Both,
-                Masking = true,
-                Children = new[]
-                {
-                    new Box
-                    {
-                        RelativeSizeAxes = Axes.Both,
-                        Alpha = 0,
-                        AlwaysPresent = true
-                    }
-                }
-            });
         }
 
         public override Color4 AccentColour
@@ -49,13 +30,6 @@ namespace osu.Game.Rulesets.Mania.Objects.Drawables
                 if (base.AccentColour == value)
                     return;
                 base.AccentColour = value;
-
-                glowContainer.EdgeEffect = new EdgeEffect
-                {
-                    Type = EdgeEffectType.Glow,
-                    Radius = 5,
-                    Colour = value
-                };
             }
         }
 
diff --git a/osu.Game.Rulesets.Mania/Objects/Drawables/Pieces/BodyPiece.cs b/osu.Game.Rulesets.Mania/Objects/Drawables/Pieces/BodyPiece.cs
index ce61a7a86f..c10aa9994b 100644
--- a/osu.Game.Rulesets.Mania/Objects/Drawables/Pieces/BodyPiece.cs
+++ b/osu.Game.Rulesets.Mania/Objects/Drawables/Pieces/BodyPiece.cs
@@ -19,7 +19,6 @@ namespace osu.Game.Rulesets.Mania.Objects.Drawables.Pieces
         public BodyPiece()
         {
             RelativeSizeAxes = Axes.Both;
-            Masking = true;
 
             Children = new[]
             {
diff --git a/osu.Game/Rulesets/Objects/Legacy/ConvertHitObjectParser.cs b/osu.Game/Rulesets/Objects/Legacy/ConvertHitObjectParser.cs
index 3b2d7211bb..a4c319291c 100644
--- a/osu.Game/Rulesets/Objects/Legacy/ConvertHitObjectParser.cs
+++ b/osu.Game/Rulesets/Objects/Legacy/ConvertHitObjectParser.cs
@@ -145,8 +145,9 @@ namespace osu.Game.Rulesets.Objects.Legacy
 
                 if (split.Length > 5 && !string.IsNullOrEmpty(split[5]))
                 {
-                    endTime = Convert.ToDouble(split[0], CultureInfo.InvariantCulture);
-                    readCustomSampleBanks(string.Join(":", split.Skip(1)), bankInfo);
+                    string[] ss = split[5].Split(':');
+                    endTime = Convert.ToDouble(ss[0], CultureInfo.InvariantCulture);
+                    readCustomSampleBanks(string.Join(":", ss.Skip(1)), bankInfo);
                 }
 
                 result = CreateHold(new Vector2(int.Parse(split[0]), int.Parse(split[1])), combo, endTime);