sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-07 16:43:52 +09:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1910 from smoogipoo/fix-alljudged-usages

Browse Source 
Fix a few usages of AllJudged possibly not being correct
This commit is contained in:
Dean Herbert
2018-01-15 16:49:42 +09:00
committed by GitHub
parent 263ffaac3f 20923321ad
commit 96242234c0
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game.Rulesets.Mania/Objects/Drawables/DrawableHoldNote.cs
View File

@ -150,7 +150,7 @@ namespace osu.Game.Rulesets.Mania.Objects.Drawables
holdStartTime = null; holdStartTime = null;
// If the key has been released too early, the user should not receive full score for the release // If the key has been released too early, the user should not receive full score for the release
if (!tail.AllJudged) if (!tail.IsHit)
hasBroken = true; hasBroken = true;
return true; return true;

2
osu.Game.Rulesets.Taiko/Objects/Drawables/DrawableDrumRoll.cs
View File

@ -81,7 +81,7 @@ namespace osu.Game.Rulesets.Taiko.Objects.Drawables
if (timeOffset < 0) if (timeOffset < 0)
return; return;
int countHit = NestedHitObjects.Count(o => o.AllJudged); int countHit = NestedHitObjects.Count(o => o.IsHit);
if (countHit > HitObject.RequiredGoodHits) if (countHit > HitObject.RequiredGoodHits)
{ {