sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-04 15:16:38 +09:00
Code Issues Packages Projects Releases Wiki Activity

Reduce unnecessary background changes via IEquatable implementation

Browse Source
This commit is contained in:
Bartłomiej Dach
2021-06-08 22:26:15 +02:00
parent f628ec25ef
commit 97204b6f27
4 changed files with 34 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
osu.Game/Screens/Backgrounds/BackgroundScreenDefault.cs
View File

@ -112,12 +112,6 @@ namespace osu.Game.Screens.Backgrounds
newBackground = new BeatmapBackgroundWithStoryboard(beatmap.Value, getBackgroundTextureName());
newBackground ??= new BeatmapBackground(beatmap.Value, getBackgroundTextureName());
// this method is called in many cases where the beatmap hasn't changed (ie. on screen transitions).
// if a background is already displayed for the requested beatmap, we don't want to load it again.
if (background?.GetType() == newBackground.GetType() &&
(background as BeatmapBackground)?.Beatmap == beatmap.Value)
return background;
break;
}
@ -127,6 +121,11 @@ namespace osu.Game.Screens.Backgrounds
}
}
// this method is called in many cases where the background might not necessarily need to change.
// if an equivalent background is currently being shown, we don't want to load it again.
if (newBackground?.Equals(background) == true)
return background;
newBackground ??= new Background(getBackgroundTextureName());
newBackground.Depth = currentDisplay;