sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-05-15 10:37:33 +09:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'master' into extend-modoverlay

Browse Source
This commit is contained in:
Dean Herbert 2018-08-15 09:23:44 +09:00 committed by GitHub
commit 9cdaefb64b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 24 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
osu.Game.Tests/Beatmaps/Formats/LegacyStoryboardDecoderTest.cs
View File

@ -86,5 +86,19 @@ namespace osu.Game.Tests.Beatmaps.Formats
Assert.AreEqual(78993, animation.StartTime); Assert.AreEqual(78993, animation.StartTime);
} }
} }
[Test]
public void TestDecodeVariableWithSuffix()
{
var decoder = new LegacyStoryboardDecoder();
using (var resStream = Resource.OpenResource("variable-with-suffix.osb"))
using (var stream = new StreamReader(resStream))
{
var storyboard = decoder.Decode(stream);
StoryboardLayer background = storyboard.Layers.Single(l => l.Depth == 3);
Assert.AreEqual(123456, ((StoryboardSprite)background.Elements.Single()).InitialPosition.X);
}
}
} }
} }

5
osu.Game.Tests/Resources/variable-with-suffix.osb Normal file
View File

@ -0,0 +1,5 @@
[Variables]
$var=1234
[Events]
Sprite,Background,TopCentre,"img.jpg",$var56,240

11
osu.Game/Beatmaps/Formats/LegacyStoryboardDecoder.cs
View File

@ -289,15 +289,10 @@ namespace osu.Game.Beatmaps.Formats
while (line.IndexOf('$') >= 0) while (line.IndexOf('$') >= 0)
{ {
string origLine = line; string origLine = line;
string[] split = line.Split(',');
for (int i = 0; i < split.Length; i++)
{
var item = split[i];
if (item.StartsWith("$") && variables.ContainsKey(item))
split[i] = variables[item];
}
line = string.Join(",", split); foreach (var v in variables)
line = line.Replace(v.Key, v.Value);
if (line == origLine) if (line == origLine)
break; break;
} }

8
osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs
View File

@ -147,17 +147,15 @@ namespace osu.Game.Rulesets.Objects.Drawables
/// </summary> /// </summary>
public void PlaySamples() => Samples?.Play(); public void PlaySamples() => Samples?.Play();
private double lastUpdateTime;
protected override void Update() protected override void Update()
{ {
base.Update(); base.Update();
if (Result != null && lastUpdateTime > Time.Current) if (Result != null && Result.HasResult)
{ {
var endTime = (HitObject as IHasEndTime)?.EndTime ?? HitObject.StartTime; var endTime = (HitObject as IHasEndTime)?.EndTime ?? HitObject.StartTime;
if (Result.TimeOffset + endTime < Time.Current) if (Result.TimeOffset + endTime > Time.Current)
{ {
OnRevertResult?.Invoke(this, Result); OnRevertResult?.Invoke(this, Result);
@ -165,8 +163,6 @@ namespace osu.Game.Rulesets.Objects.Drawables
State.Value = ArmedState.Idle; State.Value = ArmedState.Idle;
} }
} }
lastUpdateTime = Time.Current;
} }
protected override void UpdateAfterChildren() protected override void UpdateAfterChildren()