From 9de0bcae1eef5ff0beaa2fb70f26d66a62cb725e Mon Sep 17 00:00:00 2001
From: iiSaLMaN <slmanarendo1950@gmail.com>
Date: Thu, 19 Sep 2019 07:58:54 +0300
Subject: [PATCH] Check for blocking fail mods by default

---
 osu.Game/Screens/Play/Player.cs | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/osu.Game/Screens/Play/Player.cs b/osu.Game/Screens/Play/Player.cs
index fbaab61b42..e8134253f5 100644
--- a/osu.Game/Screens/Play/Player.cs
+++ b/osu.Game/Screens/Play/Player.cs
@@ -87,9 +87,11 @@ namespace osu.Game.Screens.Play
         protected new readonly Bindable<IReadOnlyList<Mod>> Mods = new Bindable<IReadOnlyList<Mod>>(Array.Empty<Mod>());
 
         /// <summary>
-        /// Whether to block the player from failing.
+        /// Whether failing should be allowed.
+        ///
+        /// By default, this checks whether any selected mod disallows failing.
         /// </summary>
-        protected virtual bool BypassFail => false;
+        protected virtual bool AllowFail => !Mods.Value.OfType<IApplicableFailOverride>().Any(m => !m.AllowFail);
 
         private readonly bool allowPause;
         private readonly bool showResults;
@@ -365,7 +367,7 @@ namespace osu.Game.Screens.Play
 
         private bool onFail()
         {
-            if (Mods.Value.OfType<IApplicableFailOverride>().Any(m => !m.AllowFail) || BypassFail)
+            if (!AllowFail)
                 return false;
 
             HasFailed = true;