sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-06 08:03:52 +09:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #18941 from peppy/fix-flaky-placeholder-test

Browse Source 
Fix flaky song select placeholder test by changing ruleset post-display
This commit is contained in:
Bartłomiej Dach
2022-06-29 23:19:13 +02:00
committed by GitHub
parent e25f686850 381deaf62d
commit 9ed676f97a
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
osu.Game.Tests/Visual/SongSelect/TestScenePlaySongSelect.cs
View File

@ -100,12 +100,13 @@ namespace osu.Game.Tests.Visual.SongSelect
[Test] [Test]
public void TestPlaceholderConvertSetting() public void TestPlaceholderConvertSetting()
{ {
changeRuleset(2);
addRulesetImportStep(0); addRulesetImportStep(0);
AddStep("change convert setting", () => config.SetValue(OsuSetting.ShowConvertedBeatmaps, false)); AddStep("change convert setting", () => config.SetValue(OsuSetting.ShowConvertedBeatmaps, false));
createSongSelect(); createSongSelect();
changeRuleset(2);
AddUntilStep("wait for placeholder visible", () => getPlaceholder()?.State.Value == Visibility.Visible); AddUntilStep("wait for placeholder visible", () => getPlaceholder()?.State.Value == Visibility.Visible);
AddStep("click link in placeholder", () => getPlaceholder().ChildrenOfType<DrawableLinkCompiler>().First().TriggerClick()); AddStep("click link in placeholder", () => getPlaceholder().ChildrenOfType<DrawableLinkCompiler>().First().TriggerClick());