sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-07-09 12:19:56 +09:00
Code Issues Packages Projects Releases Wiki Activity

Add check for spanDuration <= 0 prior to division

Browse Source
This commit is contained in:
Naxess
2021-06-27 15:40:09 +02:00
parent a4a5325b73
commit 9f9e96ce9e
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Game/Rulesets/Edit/Checks/CheckMutedObjects.cs
View File

@ -97,6 +97,10 @@ namespace osu.Game.Rulesets.Edit.Checks
if (hitObject is IHasRepeats hasRepeats) if (hitObject is IHasRepeats hasRepeats)
{ {
double spanDuration = hasRepeats.Duration / hasRepeats.SpanCount(); double spanDuration = hasRepeats.Duration / hasRepeats.SpanCount();
if (spanDuration <= 0)
// Prevents undefined behaviour in cases like where zero/negative-length sliders/hold notes exist.
return EdgeType.None;
double spans = (time - hitObject.StartTime) / spanDuration; double spans = (time - hitObject.StartTime) / spanDuration;
double acceptableDifference = 1 / spanDuration; // 1 ms of acceptable difference, as with head/tail above. double acceptableDifference = 1 / spanDuration; // 1 ms of acceptable difference, as with head/tail above.