sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-05-24 15:07:20 +09:00
Code Issues Packages Projects Releases Wiki Activity

Better limit bindable exposure of data class

Browse Source
This commit is contained in:
Dean Herbert 2020-12-16 16:08:44 +09:00
parent 6bce587b59
commit a01bb3d5a3
2 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game/Screens/Play/HUD/GameplayLeaderboard.cs
View File

@ -31,7 +31,7 @@ namespace osu.Game.Screens.Play.HUD
/// </summary> /// </summary>
/// <param name="currentScore">The bindable current score of the player.</param> /// <param name="currentScore">The bindable current score of the player.</param>
/// <param name="user">The player.</param> /// <param name="user">The player.</param>
public void AddPlayer([NotNull] BindableDouble currentScore, [NotNull] User user) public void AddPlayer([NotNull] IBindableNumber<double> currentScore, [NotNull] User user)
{ {
var scoreItem = addScore(currentScore.Value, user); var scoreItem = addScore(currentScore.Value, user);
currentScore.ValueChanged += s => scoreItem.TotalScore = s.NewValue; currentScore.ValueChanged += s => scoreItem.TotalScore = s.NewValue;

16
osu.Game/Screens/Play/HUD/MultiplayerGameplayLeaderboard.cs
View File

@ -96,11 +96,17 @@ namespace osu.Game.Screens.Play.HUD
private class TrackedUserData private class TrackedUserData
{ {
public readonly BindableDouble Score = new BindableDouble(); public IBindableNumber<double> Score => score;
public readonly BindableDouble Accuracy = new BindableDouble(); private readonly BindableDouble score = new BindableDouble();
public readonly BindableInt CurrentCombo = new BindableInt(); public IBindableNumber<double> Accuracy => accuracy;
private readonly BindableDouble accuracy = new BindableDouble();
public IBindableNumber<int> CurrentCombo => currentCombo;
private readonly BindableInt currentCombo = new BindableInt();
[CanBeNull] [CanBeNull]
public FrameHeader LastHeader; public FrameHeader LastHeader;
@ -110,9 +116,9 @@ namespace osu.Game.Screens.Play.HUD
if (LastHeader == null) if (LastHeader == null)
return; return;
(Score.Value, Accuracy.Value) = processor.GetScoreAndAccuracy(mode, LastHeader.MaxCombo, LastHeader.Statistics); (score.Value, accuracy.Value) = processor.GetScoreAndAccuracy(mode, LastHeader.MaxCombo, LastHeader.Statistics);
CurrentCombo.Value = LastHeader.Combo; currentCombo.Value = LastHeader.Combo;
} }
} }
} }