sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-07 16:43:52 +09:00
Code Issues Packages Projects Releases Wiki Activity

Fix potential crash on rare incorrect firing of skin dropdown update methods

Browse Source 
As brought to light by https://gist.github.com/smoogipoo/56eda7ab56b9d1966556f2ca7a80a847.

There's a chance that the dropdown is not populated by the time
`updateSelectedSkinFromConfig` is fired via an external means (config
changes).
This commit is contained in:
Dean Herbert
2022-03-09 01:08:11 +09:00
parent a352a140bc
commit a2ef086c1f
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
osu.Game/Overlays/Settings/Sections/SkinSection.cs
View File

@ -134,6 +134,9 @@ namespace osu.Game.Overlays.Settings.Sections
private void updateSelectedSkinFromConfig() private void updateSelectedSkinFromConfig()
{ {
if (!skinDropdown.Items.Any())
return;
Live<SkinInfo> skin = null; Live<SkinInfo> skin = null;
if (Guid.TryParse(configBindable.Value, out var configId)) if (Guid.TryParse(configBindable.Value, out var configId))