sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-02 06:07:11 +09:00
Code Issues Packages Projects Releases Wiki Activity

Apply Ruleset to Scores. Reduce complexity of score creation.

Browse Source
This commit is contained in:
Dean Herbert
2017-04-20 11:16:08 +09:00
parent 6cf026e5c1
commit a47870b376
5 changed files with 22 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
osu.Game/Rulesets/Scoring/ScoreProcessor.cs
View File

@ -61,12 +61,6 @@ namespace osu.Game.Rulesets.Scoring
Reset();
}
/// <summary>
/// Creates a Score applicable to the ruleset in which this ScoreProcessor resides.
/// </summary>
/// <returns>The Score.</returns>
public virtual Score CreateEmptyScore() => new Score();
private ScoreRank rankFrom(double acc)
{
if (acc == 1)
@ -114,10 +108,8 @@ namespace osu.Game.Rulesets.Scoring
/// <summary>
/// Retrieve a score populated with data for the current play this processor is responsible for.
/// </summary>
public virtual Score GetPopulatedScore()
public virtual void PopulateScore(Score score)
{
var score = CreateEmptyScore();
score.TotalScore = TotalScore;
score.Combo = Combo;
score.MaxCombo = HighestCombo;
@ -125,8 +117,6 @@ namespace osu.Game.Rulesets.Scoring
score.Rank = rankFrom(Accuracy);
score.Date = DateTime.Now;
score.Health = Health;
return score;
}
}