Move lifetime adjustment to DrawableHitCircle

2025-07-02 16:59:53 +09:00 · 2017-12-29 18:51:14 +09:00
parent dd2ae3f701
commit a4f941cdf1
2 changed files with 4 additions and 3 deletions
--- a/osu.Game.Rulesets.Osu/Objects/Drawables/DrawableHitCircle.cs
+++ b/osu.Game.Rulesets.Osu/Objects/Drawables/DrawableHitCircle.cs
@ -99,7 +99,11 @@ namespace osu.Game.Rulesets.Osu.Objects.Drawables
            {
                case ArmedState.Idle:
                    this.Delay(TIME_PREEMPT).FadeOut(500);
+
                    Expire(true);
+
+                    // override lifetime end as FadeIn may have been changed externally, causing out expiration to be too early.
+                    LifetimeEnd = HitObject.StartTime + HitObject.HitWindowFor(HitResult.Miss);
                    break;
                case ArmedState.Miss:
                    ApproachCircle.FadeOut(50);