sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-05 23:53:51 +09:00
Code Issues Packages Projects Releases Wiki Activity

Add mention of why the serialisation happens outside stream usage

Browse Source
This commit is contained in:
Dean Herbert
2021-10-28 15:04:09 +09:00
parent ef26b0ba8a
commit a6669a3892
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
osu.Game.Tournament/TournamentGameBase.cs
View File

@ -269,6 +269,7 @@ namespace osu.Game.Tournament
ladder.Matches.Where(p => p.LosersProgression.Value != null).Select(p => new TournamentProgression(p.ID, p.LosersProgression.Value.ID, true))) ladder.Matches.Where(p => p.LosersProgression.Value != null).Select(p => new TournamentProgression(p.ID, p.LosersProgression.Value.ID, true)))
.ToList(); .ToList();
// Serialise before opening stream for writing, so if there's a failure it will leave the file in the previous state.
string serialisedLadder = JsonConvert.SerializeObject(ladder, string serialisedLadder = JsonConvert.SerializeObject(ladder,
new JsonSerializerSettings new JsonSerializerSettings
{ {
@ -280,10 +281,8 @@ namespace osu.Game.Tournament
using (var stream = storage.GetStream(bracket_filename, FileAccess.Write, FileMode.Create)) using (var stream = storage.GetStream(bracket_filename, FileAccess.Write, FileMode.Create))
using (var sw = new StreamWriter(stream)) using (var sw = new StreamWriter(stream))
{
sw.Write(serialisedLadder); sw.Write(serialisedLadder);
} }
}
protected override UserInputManager CreateUserInputManager() => new TournamentInputManager(); protected override UserInputManager CreateUserInputManager() => new TournamentInputManager();