sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-05 15:44:04 +09:00
Code Issues Packages Projects Releases Wiki Activity

Move "flash on hit only" logic to binding

Browse Source
This commit is contained in:
Dean Herbert
2020-10-16 14:49:05 +09:00
parent 5be9e30cd0
commit a810f56ec8
2 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
osu.Game/Screens/Play/HUD/DefaultHealthDisplay.cs
View File

@ -107,13 +107,7 @@ namespace osu.Game.Screens.Play.HUD
GlowColour = colours.BlueDarker; GlowColour = colours.BlueDarker;
} }
public override void Flash(JudgementResult result) public override void Flash(JudgementResult result) => Scheduler.AddOnce(flash);
{
if (!result.IsHit)
return;
Scheduler.AddOnce(flash);
}
private void flash() private void flash()
{ {

10
osu.Game/Screens/Play/HUDOverlay.cs
View File

@ -315,8 +315,14 @@ namespace osu.Game.Screens.Play
AccuracyCounter?.Current.BindTo(processor.Accuracy); AccuracyCounter?.Current.BindTo(processor.Accuracy);
ComboCounter?.Current.BindTo(processor.Combo); ComboCounter?.Current.BindTo(processor.Combo);
if (HealthDisplay.Drawable is IHealthDisplay shd) if (HealthDisplay is IHealthDisplay shd)
processor.NewJudgement += shd.Flash; {
processor.NewJudgement += judgement =>
{
if (judgement.IsHit)
shd.Flash(judgement);
};
}
} }
protected virtual void BindHealthProcessor(HealthProcessor processor) protected virtual void BindHealthProcessor(HealthProcessor processor)