sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-06-08 04:48:04 +09:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #23111 from peppy/fix-debug-perf-drd

Browse Source 
Fix abysmal debug performance due to try-catch logic in `DrawableRulesetDependencies`
This commit is contained in:
Bartłomiej Dach 2023-04-03 21:56:13 +02:00 committed by GitHub
commit aa94e61559
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
osu.Game/Rulesets/UI/DrawableRulesetDependencies.cs
View File

@ -206,7 +206,13 @@ namespace osu.Game.Rulesets.UI
this.parent = parent; this.parent = parent;
} }
// When the debugger is attached, exceptions are expensive.
// Manually work around this by caching failed lookups and falling back straight to parent.
private readonly HashSet<(string, string)> failedLookups = new HashSet<(string, string)>();
public override IShader Load(string vertex, string fragment) public override IShader Load(string vertex, string fragment)
{
if (!failedLookups.Contains((vertex, fragment)))
{ {
try try
{ {
@ -215,9 +221,12 @@ namespace osu.Game.Rulesets.UI
catch catch
{ {
// Shader lookup is very non-standard. Rather than returning null on missing shaders, exceptions are thrown. // Shader lookup is very non-standard. Rather than returning null on missing shaders, exceptions are thrown.
failedLookups.Add((vertex, fragment));
}
}
return parent.Load(vertex, fragment); return parent.Load(vertex, fragment);
} }
} }
} }
} }
}