From abca13eb6cb934dc81f3791f8352ee4ac1ef0a95 Mon Sep 17 00:00:00 2001
From: Salman Ahmed <frenzibyte@gmail.com>
Date: Sat, 7 Jan 2023 14:30:01 +0300
Subject: [PATCH] Rewrite visualisation piece to bind once and without
 potential event leak

---
 .../Visual/Editing/TestScenePreviewTime.cs    |  4 ++--
 .../Summary/Parts/PreviewTimePart.cs          | 20 +++++++++++--------
 2 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/osu.Game.Tests/Visual/Editing/TestScenePreviewTime.cs b/osu.Game.Tests/Visual/Editing/TestScenePreviewTime.cs
index d5aa71095b..3319788c8a 100644
--- a/osu.Game.Tests/Visual/Editing/TestScenePreviewTime.cs
+++ b/osu.Game.Tests/Visual/Editing/TestScenePreviewTime.cs
@@ -27,9 +27,9 @@ namespace osu.Game.Tests.Visual.Editing
         public void TestScenePreviewTimeline()
         {
             AddStep("set preview time to -1", () => EditorBeatmap.PreviewTime.Value = -1);
-            AddAssert("preview time line should not show", () => Editor.ChildrenOfType<PreviewTimePart>().Single().Alpha == 0);
+            AddAssert("preview time line should not show", () => !Editor.ChildrenOfType<PreviewTimePart>().Single().Children.Any());
             AddStep("set preview time to 1000", () => EditorBeatmap.PreviewTime.Value = 1000);
-            AddAssert("preview time line should show", () => Editor.ChildrenOfType<PreviewTimePart>().Single().Alpha == 1);
+            AddAssert("preview time line should show", () => Editor.ChildrenOfType<PreviewTimePart>().Single().Children.Single().Alpha == 1);
         }
     }
 }
diff --git a/osu.Game/Screens/Edit/Components/Timelines/Summary/Parts/PreviewTimePart.cs b/osu.Game/Screens/Edit/Components/Timelines/Summary/Parts/PreviewTimePart.cs
index de7f611424..c63bb7ac24 100644
--- a/osu.Game/Screens/Edit/Components/Timelines/Summary/Parts/PreviewTimePart.cs
+++ b/osu.Game/Screens/Edit/Components/Timelines/Summary/Parts/PreviewTimePart.cs
@@ -10,24 +10,28 @@ namespace osu.Game.Screens.Edit.Components.Timelines.Summary.Parts
 {
     public partial class PreviewTimePart : TimelinePart
     {
+        private readonly BindableInt previewTime = new BindableInt();
+
         protected override void LoadBeatmap(EditorBeatmap beatmap)
         {
             base.LoadBeatmap(beatmap);
-            Add(new PreviewTimeVisualisation(beatmap));
-            beatmap.PreviewTime.BindValueChanged(s =>
+
+            previewTime.UnbindAll();
+            previewTime.BindTo(beatmap.PreviewTime);
+            previewTime.BindValueChanged(t =>
             {
-                Alpha = s.NewValue == -1 ? 0 : 1;
+                Clear();
+
+                if (t.NewValue >= 0)
+                    Add(new PreviewTimeVisualisation(t.NewValue));
             }, true);
         }
 
         private partial class PreviewTimeVisualisation : PointVisualisation
         {
-            private readonly BindableInt previewTime = new BindableInt();
-
-            public PreviewTimeVisualisation(EditorBeatmap editorBeatmap)
+            public PreviewTimeVisualisation(double time)
+                : base(time)
             {
-                previewTime.BindTo(editorBeatmap.PreviewTime);
-                previewTime.BindValueChanged(s => X = s.NewValue, true);
             }
 
             [BackgroundDependencyLoader]