sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-05 23:53:51 +09:00
Code Issues Packages Projects Releases Wiki Activity

Remove slider changes

Browse Source
This commit is contained in:
vmaggioli
2021-02-03 10:03:38 -05:00
parent d0fd2ae432
commit abdd417eb6
2 changed files with 1 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
osu.Game.Rulesets.Osu.Tests/Editor/TestSceneSliderSelectionBlueprint.cs
View File

@ -161,18 +161,6 @@ namespace osu.Game.Rulesets.Osu.Tests.Editor
checkControlPointSelected(1, false); checkControlPointSelected(1, false);
} }
[Test]
public void TestZeroLengthSliderNotAllowed()
{
moveMouseToControlPoint(1);
dragMouseToControlPoint(0);
moveMouseToControlPoint(2);
dragMouseToControlPoint(0);
AddAssert("slider has non-zero duration", () => slider.Duration > 0);
}
private void moveHitObject() private void moveHitObject()
{ {
AddStep("move hitobject", () => AddStep("move hitobject", () =>
@ -201,13 +189,6 @@ namespace osu.Game.Rulesets.Osu.Tests.Editor
}); });
} }
private void dragMouseToControlPoint(int index)
{
AddStep("hold down mouse button", () => InputManager.PressButton(MouseButton.Left));
moveMouseToControlPoint(index);
AddStep("release mouse button", () => InputManager.ReleaseButton(MouseButton.Left));
}
private void checkControlPointSelected(int index, bool selected) private void checkControlPointSelected(int index, bool selected)
=> AddAssert($"control point {index} {(selected ? "selected" : "not selected")}", () => blueprint.ControlPointVisualiser.Pieces[index].IsSelected.Value == selected); => AddAssert($"control point {index} {(selected ? "selected" : "not selected")}", () => blueprint.ControlPointVisualiser.Pieces[index].IsSelected.Value == selected);

6
osu.Game.Rulesets.Osu/Edit/Blueprints/Sliders/SliderSelectionBlueprint.cs
View File

@ -226,11 +226,7 @@ namespace osu.Game.Rulesets.Osu.Edit.Blueprints.Sliders
private void updatePath() private void updatePath()
{ {
float expectedDistance = composer?.GetSnappedDistanceFromDistance(HitObject.StartTime, (float)HitObject.Path.CalculatedDistance) ?? (float)HitObject.Path.CalculatedDistance; HitObject.Path.ExpectedDistance.Value = composer?.GetSnappedDistanceFromDistance(HitObject.StartTime, (float)HitObject.Path.CalculatedDistance) ?? (float)HitObject.Path.CalculatedDistance;
if (expectedDistance < 1)
return;
HitObject.Path.ExpectedDistance.Value = expectedDistance;
editorBeatmap?.Update(HitObject); editorBeatmap?.Update(HitObject);
} }