sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-07-02 16:59:53 +09:00
Code Issues Packages Projects Releases Wiki Activity

Rename method + add xmldoc

Browse Source
This commit is contained in:
smoogipoo
2019-04-22 18:08:15 +09:00
parent 910b9df2d5
commit aeae759fcd
5 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game.Rulesets.Catch/Scoring/CatchScoreProcessor.cs
View File

@ -26,7 +26,7 @@ namespace osu.Game.Rulesets.Catch.Scoring
hpDrainRate = beatmap.BeatmapInfo.BaseDifficulty.DrainRate; hpDrainRate = beatmap.BeatmapInfo.BaseDifficulty.DrainRate;
} }
protected override double HpFactorFor(JudgementResult result) protected override double HealthAdjustmentFactorFor(JudgementResult result)
{ {
switch (result.Type) switch (result.Type)
{ {

2
osu.Game.Rulesets.Mania/Scoring/ManiaScoreProcessor.cs
View File

@ -82,7 +82,7 @@ namespace osu.Game.Rulesets.Mania.Scoring
} }
} }
protected override double HpFactorFor(JudgementResult result) protected override double HealthAdjustmentFactorFor(JudgementResult result)
=> result.Type == HitResult.Miss ? hpMissMultiplier : hpMultiplier; => result.Type == HitResult.Miss ? hpMissMultiplier : hpMultiplier;
public override HitWindows CreateHitWindows() => new ManiaHitWindows(); public override HitWindows CreateHitWindows() => new ManiaHitWindows();

2
osu.Game.Rulesets.Osu/Scoring/OsuScoreProcessor.cs
View File

@ -47,7 +47,7 @@ namespace osu.Game.Rulesets.Osu.Scoring
comboResultCounts[osuResult.ComboType] = comboResultCounts.GetOrDefault(osuResult.ComboType) + 1; comboResultCounts[osuResult.ComboType] = comboResultCounts.GetOrDefault(osuResult.ComboType) + 1;
} }
protected override double HpFactorFor(JudgementResult result) protected override double HealthAdjustmentFactorFor(JudgementResult result)
{ {
switch (result.Type) switch (result.Type)
{ {

2
osu.Game.Rulesets.Taiko/Scoring/TaikoScoreProcessor.cs
View File

@ -46,7 +46,7 @@ namespace osu.Game.Rulesets.Taiko.Scoring
hpMissMultiplier = BeatmapDifficulty.DifficultyRange(beatmap.BeatmapInfo.BaseDifficulty.DrainRate, 0.0018, 0.0075, 0.0120); hpMissMultiplier = BeatmapDifficulty.DifficultyRange(beatmap.BeatmapInfo.BaseDifficulty.DrainRate, 0.0018, 0.0075, 0.0120);
} }
protected override double HpFactorFor(JudgementResult result) protected override double HealthAdjustmentFactorFor(JudgementResult result)
=> result.Type == HitResult.Miss ? hpMissMultiplier : hpMultiplier; => result.Type == HitResult.Miss ? hpMissMultiplier : hpMultiplier;
protected override void Reset(bool storeResults) protected override void Reset(bool storeResults)

9
osu.Game/Rulesets/Scoring/ScoreProcessor.cs
View File

@ -334,7 +334,7 @@ namespace osu.Game.Rulesets.Scoring
rollingMaxBaseScore += result.Judgement.MaxNumericResult; rollingMaxBaseScore += result.Judgement.MaxNumericResult;
} }
Health.Value += HpFactorFor(result) * result.Judgement.HealthIncreaseFor(result); Health.Value += HealthAdjustmentFactorFor(result) * result.Judgement.HealthIncreaseFor(result);
} }
/// <summary> /// <summary>
@ -362,7 +362,12 @@ namespace osu.Game.Rulesets.Scoring
} }
} }
protected virtual double HpFactorFor(JudgementResult result) => 1; /// <summary>
/// An adjustment factor which is multiplied into the health increase provided by a <see cref="JudgementResult"/>.
/// </summary>
/// <param name="result">The <see cref="JudgementResult"/> for which the adjustment should apply.</param>
/// <returns>The adjustment factor.</returns>
protected virtual double HealthAdjustmentFactorFor(JudgementResult result) => 1;
private void updateScore() private void updateScore()
{ {