Cleanup positioning factor definition

This commit is contained in:
smoogipoo
2020-04-02 14:24:09 +09:00
parent 09eb9facdd
commit b375a02cff
3 changed files with 48 additions and 21 deletions

View File

@ -7,14 +7,24 @@ namespace osu.Game.Skinning
{
public class LegacyManiaSkinConfiguration
{
/// <summary>
/// Conversion factor from converting legacy positioning values (based in x480 dimensions) to x768.
/// </summary>
public const float POSITION_SCALE_FACTOR = 1.6f;
/// <summary>
/// Size of a legacy column in the default skin, used for determining relative scale factors.
/// </summary>
public const float DEFAULT_COLUMN_SIZE = 30 * POSITION_SCALE_FACTOR;
public readonly int Keys;
public readonly float[] ColumnLineWidth;
public readonly float[] ColumnSpacing;
public readonly float[] ColumnWidth;
public float HitPosition = 124.8f; // (480 - 402) * 1.6f
public float LightPosition = 107.2f; // (480 - 413) * 1.6f
public float HitPosition = (480 - 402) * POSITION_SCALE_FACTOR;
public float LightPosition = (480 - 413) * POSITION_SCALE_FACTOR;
public bool ShowJudgementLine = true;
public LegacyManiaSkinConfiguration(int keys)
@ -26,7 +36,7 @@ namespace osu.Game.Skinning
ColumnWidth = new float[keys];
ColumnLineWidth.AsSpan().Fill(2);
ColumnWidth.AsSpan().Fill(48);
ColumnWidth.AsSpan().Fill(DEFAULT_COLUMN_SIZE);
}
}
}