sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-06-23 12:18:03 +09:00
Code Issues Packages Projects Releases Wiki Activity

Avoid potential feedback from bindable event binds

Browse Source
This commit is contained in:
Dean Herbert 2021-02-10 15:32:57 +09:00
parent 67c1c4c1eb
commit b3b0d97354
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
osu.Game/Overlays/Mods/ModSelectOverlay.cs
View File

@ -371,8 +371,11 @@ namespace osu.Game.Overlays.Mods
{ {
base.LoadComplete(); base.LoadComplete();
SelectedMods.BindValueChanged(_ => updateSelectedButtons());
availableMods.BindValueChanged(_ => updateAvailableMods(), true); availableMods.BindValueChanged(_ => updateAvailableMods(), true);
// intentionally bound after the above line to avoid a potential update feedback cycle.
// i haven't actually observed this happening but as updateAvailableMods() changes the selection it is plausible.
SelectedMods.BindValueChanged(_ => updateSelectedButtons());
} }
protected override void PopOut() protected override void PopOut()