sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-05 15:44:04 +09:00
Code Issues Packages Projects Releases Wiki Activity

Remove settings

Browse Source
This commit is contained in:
Spooghetti420
2022-01-30 17:40:15 +00:00
parent c7580a5177
commit b52153e73d
2 changed files with 10 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
osu.Game.Rulesets.Mania/Mods/ManiaModHoldOff.cs
View File

@ -6,11 +6,8 @@ using osu.Game.Beatmaps;
using osu.Game.Rulesets.Mania.Objects;
using osu.Game.Rulesets.Mods;
using osu.Framework.Graphics.Sprites;
using System;
using System.Collections.Generic;
using osu.Game.Rulesets.Mania.Beatmaps;
using osu.Framework.Bindables;
using osu.Game.Configuration;
namespace osu.Game.Rulesets.Mania.Mods
{
@ -27,23 +24,13 @@ namespace osu.Game.Rulesets.Mania.Mods
public override IconUsage? Icon => FontAwesome.Solid.DotCircle;
public override ModType Type => ModType.Conversion;
[SettingSource("Add end notes", "Also add a note at the end of a hold note")]
public BindableBool AddEndNotes { get; } = new BindableBool
{
Default = true,
Value = true
};
[SettingSource("Minimum end note beat snap", "Don't add end notes for hold notes shorter than this beat division")]
public Bindable<BeatDivisors> MinBeatSnap { get; } = new Bindable<BeatDivisors>(defaultValue: BeatDivisors.Half);
public const double Threshold = 1/2;
public void ApplyToBeatmap(IBeatmap beatmap)
{
var maniaBeatmap = (ManiaBeatmap)beatmap;
var newObjects = new List<ManiaHitObject>();
double beatSnap = 1 / (Math.Pow(2, (double)MinBeatSnap.Value));
foreach (var h in beatmap.HitObjects.OfType<HoldNote>())
{
@ -55,10 +42,10 @@ namespace osu.Game.Rulesets.Mania.Mods
Samples = h.GetNodeSamples(0)
});
// Don't add an end note if the duration is shorter than some threshold, or end notes are disabled
// Don't add an end note if the duration is shorter than the threshold
double noteValue = GetNoteDurationInBeatLength(h, maniaBeatmap); // 1/1, 1/2, 1/4, etc.
if (AddEndNotes.Value && noteValue >= beatSnap)
if (noteValue >= Threshold)
{
newObjects.Add(new Note
{
@ -77,14 +64,5 @@ namespace osu.Game.Rulesets.Mania.Mods
double bpmAtNoteTime = beatmap.ControlPointInfo.TimingPointAt(holdNote.StartTime).BPM;
return (60 * holdNote.Duration) / (1000 * bpmAtNoteTime);
}
public enum BeatDivisors
{
Whole,
Half,
Quarter,
Eighth,
Sixteenth
}
}
}