sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-07-01 16:29:58 +09:00
Code Issues Packages Projects Releases Wiki Activity

Undo disposal of Stream for use in mocking

Browse Source 
Because the Stream object is accessed when the mocked object calls `GetStream`, we cannot close it here.

The resource should be released upon teardown anyway.
This commit is contained in:
Naxesss
2021-10-12 00:35:58 +02:00
parent d4779f06cf
commit bb9cbd3e66
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game.Tests/Editing/Checks/CheckAudioInVideoTest.cs
View File

@ -83,7 +83,7 @@ namespace osu.Game.Tests.Editing.Checks
private BeatmapVerifierContext getContext(string resourceName, bool allowMissing = false) private BeatmapVerifierContext getContext(string resourceName, bool allowMissing = false)
{ {
using Stream resourceStream = string.IsNullOrEmpty(resourceName) ? null : TestResources.OpenResource(resourceName); Stream resourceStream = string.IsNullOrEmpty(resourceName) ? null : TestResources.OpenResource(resourceName);
if (!allowMissing && resourceStream == null) if (!allowMissing && resourceStream == null)
throw new FileNotFoundException($"The requested test resource \"{resourceName}\" does not exist."); throw new FileNotFoundException($"The requested test resource \"{resourceName}\" does not exist.");

2
osu.Game.Tests/Editing/Checks/CheckTooShortAudioFilesTest.cs
View File

@ -104,7 +104,7 @@ namespace osu.Game.Tests.Editing.Checks
private BeatmapVerifierContext getContext(string resourceName, bool allowMissing = false) private BeatmapVerifierContext getContext(string resourceName, bool allowMissing = false)
{ {
using Stream resourceStream = string.IsNullOrEmpty(resourceName) ? null : TestResources.OpenResource(resourceName); Stream resourceStream = string.IsNullOrEmpty(resourceName) ? null : TestResources.OpenResource(resourceName);
if (!allowMissing && resourceStream == null) if (!allowMissing && resourceStream == null)
throw new FileNotFoundException($"The requested test resource \"{resourceName}\" does not exist."); throw new FileNotFoundException($"The requested test resource \"{resourceName}\" does not exist.");