From 8ad782a82d71b03d6f17bec85b35bbacf6e30102 Mon Sep 17 00:00:00 2001
From: Andrei Zavatski <megaman9919@gmail.com>
Date: Sat, 14 Sep 2019 06:16:25 +0300
Subject: [PATCH 1/2] Fix RankingsHeader dropdown can be clickable when not
 visible

---
 osu.Game/Overlays/Rankings/RankingsHeader.cs | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/osu.Game/Overlays/Rankings/RankingsHeader.cs b/osu.Game/Overlays/Rankings/RankingsHeader.cs
index fbf3097f4f..13c1f0fe40 100644
--- a/osu.Game/Overlays/Rankings/RankingsHeader.cs
+++ b/osu.Game/Overlays/Rankings/RankingsHeader.cs
@@ -31,7 +31,6 @@ namespace osu.Game.Overlays.Rankings
         public readonly Bindable<Country> Country = new Bindable<Country>();
         public readonly Bindable<Spotlight> Spotlight = new Bindable<Spotlight>();
 
-        private readonly Container dropdownPlaceholder;
         private readonly OsuDropdown<Spotlight> dropdown;
 
         public RankingsHeader()
@@ -86,14 +85,13 @@ namespace osu.Game.Overlays.Rankings
                                         Scope = { BindTarget = Scope },
                                         Country = { BindTarget = Country },
                                     },
-                                    dropdownPlaceholder = new Container
+                                    new Container
                                     {
                                         Anchor = Anchor.TopCentre,
                                         Origin = Anchor.TopCentre,
                                         RelativeSizeAxes = Axes.X,
                                         Height = dropdown_height,
                                         Width = 0.8f,
-                                        AlwaysPresent = true,
                                         Child = dropdown = new OsuDropdown<Spotlight>
                                         {
                                             RelativeSizeAxes = Axes.X,
@@ -115,7 +113,7 @@ namespace osu.Game.Overlays.Rankings
         }
 
         private void onScopeChanged(ValueChangedEvent<RankingsScope> scope) =>
-            dropdownPlaceholder.FadeTo(scope.NewValue == RankingsScope.Spotlights ? 1 : 0, 200, Easing.OutQuint);
+            dropdown.FadeTo(scope.NewValue == RankingsScope.Spotlights ? 1 : 0, 200, Easing.OutQuint);
 
         private class HeaderBackground : Sprite
         {

From 2783ae62ef7b409b5b6a5d9f4f3867d1553d2bf6 Mon Sep 17 00:00:00 2001
From: Andrei Zavatski <megaman9919@gmail.com>
Date: Sat, 14 Sep 2019 06:34:57 +0300
Subject: [PATCH 2/2] Remove useless container

---
 osu.Game/Overlays/Rankings/RankingsHeader.cs | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/osu.Game/Overlays/Rankings/RankingsHeader.cs b/osu.Game/Overlays/Rankings/RankingsHeader.cs
index 13c1f0fe40..6aa3e75df9 100644
--- a/osu.Game/Overlays/Rankings/RankingsHeader.cs
+++ b/osu.Game/Overlays/Rankings/RankingsHeader.cs
@@ -18,7 +18,6 @@ namespace osu.Game.Overlays.Rankings
     public class RankingsHeader : CompositeDrawable
     {
         private const int content_height = 250;
-        private const int dropdown_height = 50;
 
         public IEnumerable<Spotlight> Spotlights
         {
@@ -85,18 +84,13 @@ namespace osu.Game.Overlays.Rankings
                                         Scope = { BindTarget = Scope },
                                         Country = { BindTarget = Country },
                                     },
-                                    new Container
+                                    dropdown = new OsuDropdown<Spotlight>
                                     {
                                         Anchor = Anchor.TopCentre,
                                         Origin = Anchor.TopCentre,
                                         RelativeSizeAxes = Axes.X,
-                                        Height = dropdown_height,
                                         Width = 0.8f,
-                                        Child = dropdown = new OsuDropdown<Spotlight>
-                                        {
-                                            RelativeSizeAxes = Axes.X,
-                                            Current = Spotlight,
-                                        }
+                                        Current = Spotlight,
                                     }
                                 }
                             },