sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-05 15:44:04 +09:00
Code Issues Packages Projects Releases Wiki Activity

Remove exceptions instead

Browse Source
This commit is contained in:
Dean Herbert
2020-04-18 21:46:04 +09:00
parent 61e3491e60
commit c00a386ff6
2 changed files with 5 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
osu.Game/Beatmaps/Formats/LegacyBeatmapEncoder.cs
View File

@ -194,20 +194,7 @@ namespace osu.Game.Beatmaps.Formats
handleOsuHitObject(writer, h); handleOsuHitObject(writer, h);
break; break;
case 1: // TODO: implement other legacy rulesets
foreach (var h in beatmap.HitObjects)
handleTaikoHitObject(writer, h);
break;
case 2:
foreach (var h in beatmap.HitObjects)
handleCatchHitObject(writer, h);
break;
case 3:
foreach (var h in beatmap.HitObjects)
handleManiaHitObject(writer, h);
break;
} }
} }
@ -328,12 +315,6 @@ namespace osu.Game.Beatmaps.Formats
} }
} }
private void handleTaikoHitObject(TextWriter writer, HitObject hitObject) => throw new NotImplementedException();
private void handleCatchHitObject(TextWriter writer, HitObject hitObject) => throw new NotImplementedException();
private void handleManiaHitObject(TextWriter writer, HitObject hitObject) => throw new NotImplementedException();
private string getSampleBank(IList<HitSampleInfo> samples, bool banksOnly = false, bool zeroBanks = false) private string getSampleBank(IList<HitSampleInfo> samples, bool banksOnly = false, bool zeroBanks = false)
{ {
LegacySampleBank normalBank = toLegacySampleBank(samples.SingleOrDefault(s => s.Name == HitSampleInfo.HIT_NORMAL)?.Bank); LegacySampleBank normalBank = toLegacySampleBank(samples.SingleOrDefault(s => s.Name == HitSampleInfo.HIT_NORMAL)?.Bank);

15
osu.Game/Screens/Edit/EditorChangeHandler.cs
View File

@ -82,19 +82,12 @@ namespace osu.Game.Screens.Edit
if (savedStates.Count > MAX_SAVED_STATES) if (savedStates.Count > MAX_SAVED_STATES)
savedStates.RemoveAt(0); savedStates.RemoveAt(0);
try using (var stream = new MemoryStream())
{ {
using (var stream = new MemoryStream()) using (var sw = new StreamWriter(stream, Encoding.UTF8, 1024, true))
{ new LegacyBeatmapEncoder(editorBeatmap).Encode(sw);
using (var sw = new StreamWriter(stream, Encoding.UTF8, 1024, true))
new LegacyBeatmapEncoder(editorBeatmap).Encode(sw);
savedStates.Add(stream.ToArray()); savedStates.Add(stream.ToArray());
}
}
catch (NotImplementedException)
{
// some rulesets don't have encoder implementations yet.
} }
currentState = savedStates.Count - 1; currentState = savedStates.Count - 1;