From c0b388cd74e864f6654d161e4bd631ca36408b0c Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Tue, 17 Aug 2021 17:50:30 +0900
Subject: [PATCH] Fix regression in `ModSettingsChangeTracker`

---
 osu.Game/Overlays/Settings/SettingsItem.cs | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/osu.Game/Overlays/Settings/SettingsItem.cs b/osu.Game/Overlays/Settings/SettingsItem.cs
index c35690151c..6621caef4e 100644
--- a/osu.Game/Overlays/Settings/SettingsItem.cs
+++ b/osu.Game/Overlays/Settings/SettingsItem.cs
@@ -119,19 +119,19 @@ namespace osu.Game.Overlays.Settings
                     },
                 },
             };
-        }
 
-        [BackgroundDependencyLoader]
-        private void load()
-        {
-            // all bindable logic is in constructor intentionally to support "CreateSettingsControls" being used in a context it is
+            // IMPORTANT: all bindable logic is in constructor intentionally to support "CreateSettingsControls" being used in a context it is
             // never loaded, but requires bindable storage.
             if (controlWithCurrent == null)
                 throw new ArgumentException(@$"Control created via {nameof(CreateControl)} must implement {nameof(IHasCurrentValue<T>)}");
 
             controlWithCurrent.Current.ValueChanged += _ => SettingChanged?.Invoke();
             controlWithCurrent.Current.DisabledChanged += _ => updateDisabled();
+        }
 
+        [BackgroundDependencyLoader]
+        private void load()
+        {
             // intentionally done before LoadComplete to avoid overhead.
             if (ShowsDefaultIndicator)
             {