sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-05-05 21:57:24 +09:00
Code Issues Packages Projects Releases Wiki Activity

Change default IsBonus definition and remove unnecessary overrides

Browse Source
This commit is contained in:
Dean Herbert 2018-06-29 17:07:08 +09:00
parent cacabeb67e
commit c0b65a6a73
7 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
osu.Game.Rulesets.Catch/Judgements/CatchBananaJudgement.cs
View File

@ -8,7 +8,6 @@ namespace osu.Game.Rulesets.Catch.Judgements
public class CatchBananaJudgement : CatchJudgement public class CatchBananaJudgement : CatchJudgement
{ {
public override bool AffectsCombo => false; public override bool AffectsCombo => false;
public override bool IsBonus => true;
public override bool ShouldExplode => true; public override bool ShouldExplode => true;

1
osu.Game.Rulesets.Mania/Judgements/HoldNoteJudgement.cs
View File

@ -8,7 +8,6 @@ namespace osu.Game.Rulesets.Mania.Judgements
public class HoldNoteJudgement : ManiaJudgement public class HoldNoteJudgement : ManiaJudgement
{ {
public override bool AffectsCombo => false; public override bool AffectsCombo => false;
public override bool IsBonus => true;
protected override int NumericResultFor(HitResult result) => 0; protected override int NumericResultFor(HitResult result) => 0;
} }

1
osu.Game.Rulesets.Mania/Judgements/HoldNoteTickJudgement.cs
View File

@ -8,7 +8,6 @@ namespace osu.Game.Rulesets.Mania.Judgements
public class HoldNoteTickJudgement : ManiaJudgement public class HoldNoteTickJudgement : ManiaJudgement
{ {
public override bool AffectsCombo => false; public override bool AffectsCombo => false;
public override bool IsBonus => true;
protected override int NumericResultFor(HitResult result) => 20; protected override int NumericResultFor(HitResult result) => 20;
} }

1
osu.Game.Rulesets.Osu/Judgements/OsuSliderTailJudgement.cs
View File

@ -8,7 +8,6 @@ namespace osu.Game.Rulesets.Osu.Judgements
public class OsuSliderTailJudgement : OsuJudgement public class OsuSliderTailJudgement : OsuJudgement
{ {
public override bool AffectsCombo => false; public override bool AffectsCombo => false;
public override bool IsBonus => true;
protected override int NumericResultFor(HitResult result) => 0; protected override int NumericResultFor(HitResult result) => 0;
} }

1
osu.Game.Rulesets.Taiko/Judgements/TaikoDrumRollTickJudgement.cs
View File

@ -8,7 +8,6 @@ namespace osu.Game.Rulesets.Taiko.Judgements
public class TaikoDrumRollTickJudgement : TaikoJudgement public class TaikoDrumRollTickJudgement : TaikoJudgement
{ {
public override bool AffectsCombo => false; public override bool AffectsCombo => false;
public override bool IsBonus => true;
protected override int NumericResultFor(HitResult result) protected override int NumericResultFor(HitResult result)
{ {

1
osu.Game.Rulesets.Taiko/Judgements/TaikoStrongHitJudgement.cs
View File

@ -6,7 +6,6 @@ namespace osu.Game.Rulesets.Taiko.Judgements
public class TaikoStrongHitJudgement : TaikoJudgement public class TaikoStrongHitJudgement : TaikoJudgement
{ {
public override bool AffectsCombo => false; public override bool AffectsCombo => false;
public override bool IsBonus => true;
public TaikoStrongHitJudgement() public TaikoStrongHitJudgement()
{ {

2
osu.Game/Rulesets/Judgements/Judgement.cs
View File

@ -52,7 +52,7 @@ namespace osu.Game.Rulesets.Judgements
/// <summary> /// <summary>
/// Whether the <see cref="Result"/> should be counted as base or bonus score. /// Whether the <see cref="Result"/> should be counted as base or bonus score.
/// </summary> /// </summary>
public virtual bool IsBonus => false; public virtual bool IsBonus => !AffectsCombo;
/// <summary> /// <summary>
/// The numeric representation for the result achieved. /// The numeric representation for the result achieved.